Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: content/renderer/media/rtc_peer_connection_handler_unittest.cc

Issue 2395503002: WebRTCStatsMember: Support for bool and sequence of bool (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/rtc_peer_connection_handler.h" 5 #include "content/renderer/media/rtc_peer_connection_handler.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <set> 10 #include <set>
(...skipping 662 matching lines...) Expand 10 before | Expand all | Expand 10 after
673 673
674 TEST_F(RTCPeerConnectionHandlerTest, GetRTCStats) { 674 TEST_F(RTCPeerConnectionHandlerTest, GetRTCStats) {
675 rtc::scoped_refptr<webrtc::RTCStatsReport> report = 675 rtc::scoped_refptr<webrtc::RTCStatsReport> report =
676 webrtc::RTCStatsReport::Create(); 676 webrtc::RTCStatsReport::Create();
677 677
678 report->AddStats(std::unique_ptr<const webrtc::RTCStats>( 678 report->AddStats(std::unique_ptr<const webrtc::RTCStats>(
679 new webrtc::RTCTestStats("RTCUndefinedStats", 1000))); 679 new webrtc::RTCTestStats("RTCUndefinedStats", 1000)));
680 680
681 std::unique_ptr<webrtc::RTCTestStats> stats_defined_members( 681 std::unique_ptr<webrtc::RTCTestStats> stats_defined_members(
682 new webrtc::RTCTestStats("RTCDefinedStats", 2000)); 682 new webrtc::RTCTestStats("RTCDefinedStats", 2000));
683 stats_defined_members->m_bool = true;
683 stats_defined_members->m_int32 = 42; 684 stats_defined_members->m_int32 = 42;
684 stats_defined_members->m_uint32 = 42; 685 stats_defined_members->m_uint32 = 42;
685 stats_defined_members->m_int64 = 42; 686 stats_defined_members->m_int64 = 42;
686 stats_defined_members->m_uint64 = 42; 687 stats_defined_members->m_uint64 = 42;
687 stats_defined_members->m_double = 42.0; 688 stats_defined_members->m_double = 42.0;
688 stats_defined_members->m_string = "42"; 689 stats_defined_members->m_string = "42";
690 stats_defined_members->m_sequence_bool = ToSequence<bool>(true);
689 stats_defined_members->m_sequence_int32 = ToSequence<int32_t>(42); 691 stats_defined_members->m_sequence_int32 = ToSequence<int32_t>(42);
690 stats_defined_members->m_sequence_uint32 = ToSequence<uint32_t>(42); 692 stats_defined_members->m_sequence_uint32 = ToSequence<uint32_t>(42);
691 stats_defined_members->m_sequence_int64 = ToSequence<int64_t>(42); 693 stats_defined_members->m_sequence_int64 = ToSequence<int64_t>(42);
692 stats_defined_members->m_sequence_uint64 = ToSequence<uint64_t>(42); 694 stats_defined_members->m_sequence_uint64 = ToSequence<uint64_t>(42);
693 stats_defined_members->m_sequence_double = ToSequence<double>(42); 695 stats_defined_members->m_sequence_double = ToSequence<double>(42);
694 stats_defined_members->m_sequence_string = ToSequence<std::string>("42"); 696 stats_defined_members->m_sequence_string = ToSequence<std::string>("42");
695 report->AddStats(std::unique_ptr<const webrtc::RTCStats>( 697 report->AddStats(std::unique_ptr<const webrtc::RTCStats>(
696 stats_defined_members.release())); 698 stats_defined_members.release()));
697 699
698 pc_handler_->native_peer_connection()->SetGetStatsReport(report); 700 pc_handler_->native_peer_connection()->SetGetStatsReport(report);
(...skipping 23 matching lines...) Expand all
722 stats->getMember(i); 724 stats->getMember(i);
723 // TODO(hbos): A WebRTC-change is adding new members, this would cause 725 // TODO(hbos): A WebRTC-change is adding new members, this would cause
724 // not all members to be defined. This if-statement saves Chromium from 726 // not all members to be defined. This if-statement saves Chromium from
725 // crashing. As soon as the change has been rolled in, I will update 727 // crashing. As soon as the change has been rolled in, I will update
726 // this test. crbug.com/627816 728 // this test. crbug.com/627816
727 if (!member->isDefined()) 729 if (!member->isDefined())
728 continue; 730 continue;
729 EXPECT_TRUE(member->isDefined()); 731 EXPECT_TRUE(member->isDefined());
730 members.insert(member->type()); 732 members.insert(member->type());
731 switch (member->type()) { 733 switch (member->type()) {
734 case blink::WebRTCStatsMemberTypeBool:
735 EXPECT_EQ(member->valueBool(), true);
736 break;
732 case blink::WebRTCStatsMemberTypeInt32: 737 case blink::WebRTCStatsMemberTypeInt32:
733 EXPECT_EQ(member->valueInt32(), static_cast<int32_t>(42)); 738 EXPECT_EQ(member->valueInt32(), static_cast<int32_t>(42));
734 break; 739 break;
735 case blink::WebRTCStatsMemberTypeUint32: 740 case blink::WebRTCStatsMemberTypeUint32:
736 EXPECT_EQ(member->valueUint32(), static_cast<uint32_t>(42)); 741 EXPECT_EQ(member->valueUint32(), static_cast<uint32_t>(42));
737 break; 742 break;
738 case blink::WebRTCStatsMemberTypeInt64: 743 case blink::WebRTCStatsMemberTypeInt64:
739 EXPECT_EQ(member->valueInt64(), static_cast<int64_t>(42)); 744 EXPECT_EQ(member->valueInt64(), static_cast<int64_t>(42));
740 break; 745 break;
741 case blink::WebRTCStatsMemberTypeUint64: 746 case blink::WebRTCStatsMemberTypeUint64:
742 EXPECT_EQ(member->valueUint64(), static_cast<uint64_t>(42)); 747 EXPECT_EQ(member->valueUint64(), static_cast<uint64_t>(42));
743 break; 748 break;
744 case blink::WebRTCStatsMemberTypeDouble: 749 case blink::WebRTCStatsMemberTypeDouble:
745 EXPECT_EQ(member->valueDouble(), 42.0); 750 EXPECT_EQ(member->valueDouble(), 42.0);
746 break; 751 break;
747 case blink::WebRTCStatsMemberTypeString: 752 case blink::WebRTCStatsMemberTypeString:
748 EXPECT_EQ(member->valueString(), blink::WebString::fromUTF8("42")); 753 EXPECT_EQ(member->valueString(), blink::WebString::fromUTF8("42"));
749 break; 754 break;
755 case blink::WebRTCStatsMemberTypeSequenceBool:
756 ExpectSequenceEquals(member->valueSequenceBool(), 1);
757 break;
750 case blink::WebRTCStatsMemberTypeSequenceInt32: 758 case blink::WebRTCStatsMemberTypeSequenceInt32:
751 ExpectSequenceEquals(member->valueSequenceInt32(), 759 ExpectSequenceEquals(member->valueSequenceInt32(),
752 static_cast<int32_t>(42)); 760 static_cast<int32_t>(42));
753 break; 761 break;
754 case blink::WebRTCStatsMemberTypeSequenceUint32: 762 case blink::WebRTCStatsMemberTypeSequenceUint32:
755 ExpectSequenceEquals(member->valueSequenceUint32(), 763 ExpectSequenceEquals(member->valueSequenceUint32(),
756 static_cast<uint32_t>(42)); 764 static_cast<uint32_t>(42));
757 break; 765 break;
758 case blink::WebRTCStatsMemberTypeSequenceInt64: 766 case blink::WebRTCStatsMemberTypeSequenceInt64:
759 ExpectSequenceEquals(member->valueSequenceInt64(), 767 ExpectSequenceEquals(member->valueSequenceInt64(),
760 static_cast<int64_t>(42)); 768 static_cast<int64_t>(42));
761 break; 769 break;
762 case blink::WebRTCStatsMemberTypeSequenceUint64: 770 case blink::WebRTCStatsMemberTypeSequenceUint64:
763 ExpectSequenceEquals(member->valueSequenceUint64(), 771 ExpectSequenceEquals(member->valueSequenceUint64(),
764 static_cast<uint64_t>(42)); 772 static_cast<uint64_t>(42));
765 break; 773 break;
766 case blink::WebRTCStatsMemberTypeSequenceDouble: 774 case blink::WebRTCStatsMemberTypeSequenceDouble:
767 ExpectSequenceEquals(member->valueSequenceDouble(), 42.0); 775 ExpectSequenceEquals(member->valueSequenceDouble(), 42.0);
768 break; 776 break;
769 case blink::WebRTCStatsMemberTypeSequenceString: 777 case blink::WebRTCStatsMemberTypeSequenceString:
770 ExpectSequenceEquals(member->valueSequenceString(), 778 ExpectSequenceEquals(member->valueSequenceString(),
771 blink::WebString::fromUTF8("42")); 779 blink::WebString::fromUTF8("42"));
772 break; 780 break;
773 default: 781 default:
774 NOTREACHED(); 782 NOTREACHED();
775 } 783 }
776 } 784 }
777 EXPECT_EQ(members.size(), static_cast<size_t>(12)); 785 EXPECT_EQ(members.size(), static_cast<size_t>(14));
778 } else { 786 } else {
779 NOTREACHED(); 787 NOTREACHED();
780 } 788 }
781 } 789 }
782 EXPECT_EQ(undefined_stats_count, 1); 790 EXPECT_EQ(undefined_stats_count, 1);
783 EXPECT_EQ(defined_stats_count, 1); 791 EXPECT_EQ(defined_stats_count, 1);
784 } 792 }
785 793
786 TEST_F(RTCPeerConnectionHandlerTest, OnSignalingChange) { 794 TEST_F(RTCPeerConnectionHandlerTest, OnSignalingChange) {
787 testing::InSequence sequence; 795 testing::InSequence sequence;
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
1205 testing::Ref(tracks[0]))); 1213 testing::Ref(tracks[0])));
1206 1214
1207 std::unique_ptr<blink::WebRTCDTMFSenderHandler> sender( 1215 std::unique_ptr<blink::WebRTCDTMFSenderHandler> sender(
1208 pc_handler_->createDTMFSender(tracks[0])); 1216 pc_handler_->createDTMFSender(tracks[0]));
1209 EXPECT_TRUE(sender.get()); 1217 EXPECT_TRUE(sender.get());
1210 1218
1211 StopAllTracks(local_stream); 1219 StopAllTracks(local_stream);
1212 } 1220 }
1213 1221
1214 } // namespace content 1222 } // namespace content
OLDNEW
« no previous file with comments | « components/test_runner/mock_webrtc_peer_connection_handler.cc ('k') | content/renderer/media/webrtc/rtc_stats.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698