Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2577)

Unified Diff: content/renderer/media/rtc_peer_connection_handler_unittest.cc

Issue 2395503002: WebRTCStatsMember: Support for bool and sequence of bool (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_peer_connection_handler_unittest.cc
diff --git a/content/renderer/media/rtc_peer_connection_handler_unittest.cc b/content/renderer/media/rtc_peer_connection_handler_unittest.cc
index c9d99a01b906141671adafdb0ef48b69d8dfed2d..568f6e5d5a3508b4f6510a8453739fc9cbf42714 100644
--- a/content/renderer/media/rtc_peer_connection_handler_unittest.cc
+++ b/content/renderer/media/rtc_peer_connection_handler_unittest.cc
@@ -680,12 +680,14 @@ TEST_F(RTCPeerConnectionHandlerTest, GetRTCStats) {
std::unique_ptr<webrtc::RTCTestStats> stats_defined_members(
new webrtc::RTCTestStats("RTCDefinedStats", 2000));
+ stats_defined_members->m_bool = true;
stats_defined_members->m_int32 = 42;
stats_defined_members->m_uint32 = 42;
stats_defined_members->m_int64 = 42;
stats_defined_members->m_uint64 = 42;
stats_defined_members->m_double = 42.0;
stats_defined_members->m_string = "42";
+ stats_defined_members->m_sequence_bool = ToSequence<bool>(true);
stats_defined_members->m_sequence_int32 = ToSequence<int32_t>(42);
stats_defined_members->m_sequence_uint32 = ToSequence<uint32_t>(42);
stats_defined_members->m_sequence_int64 = ToSequence<int64_t>(42);
@@ -729,6 +731,9 @@ TEST_F(RTCPeerConnectionHandlerTest, GetRTCStats) {
EXPECT_TRUE(member->isDefined());
members.insert(member->type());
switch (member->type()) {
+ case blink::WebRTCStatsMemberTypeBool:
+ EXPECT_EQ(member->valueBool(), true);
+ break;
case blink::WebRTCStatsMemberTypeInt32:
EXPECT_EQ(member->valueInt32(), static_cast<int32_t>(42));
break;
@@ -747,6 +752,9 @@ TEST_F(RTCPeerConnectionHandlerTest, GetRTCStats) {
case blink::WebRTCStatsMemberTypeString:
EXPECT_EQ(member->valueString(), blink::WebString::fromUTF8("42"));
break;
+ case blink::WebRTCStatsMemberTypeSequenceBool:
+ ExpectSequenceEquals(member->valueSequenceBool(), 1);
+ break;
case blink::WebRTCStatsMemberTypeSequenceInt32:
ExpectSequenceEquals(member->valueSequenceInt32(),
static_cast<int32_t>(42));
@@ -774,7 +782,7 @@ TEST_F(RTCPeerConnectionHandlerTest, GetRTCStats) {
NOTREACHED();
}
}
- EXPECT_EQ(members.size(), static_cast<size_t>(12));
+ EXPECT_EQ(members.size(), static_cast<size_t>(14));
} else {
NOTREACHED();
}
« no previous file with comments | « components/test_runner/mock_webrtc_peer_connection_handler.cc ('k') | content/renderer/media/webrtc/rtc_stats.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698