Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 239543013: Work on Mac GN build (Closed)

Created:
6 years, 8 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
Nico, scottmg
CC:
chromium-reviews, tfarina, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Work on Mac GN build. This fixes a lot of minor mistakes (mostly missing/extra files and flags) for the Mac GN build. I separated out some clang flags into a config for extra clang warnings. Several of the third party libraries needed to remove this. Removes the use_nss flag and uses !use_openssl. This is a result of discussion with rsleevi. Removes extra duplicate net build file from secondary tree. ui/gesture_events seems to be getting compiled in GN with more strict warnings than in GYP. Rather than fix this, I fixed the warning in the gesture recognizer unit test. It was returning a const copy (the const is pointless when you're copying). This also removes a bunch of old GYP integration stuff that was left in the GN build. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264626

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Remove use_nss #

Total comments: 1

Patch Set 5 : fix line endings #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -1583 lines) Patch
M build/config/BUILD.gn View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 2 3 chunks +4 lines, -12 lines 0 comments Download
M build/config/clang/BUILD.gn View 1 1 chunk +11 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 chunks +0 lines, -7 lines 0 comments Download
M build/config/crypto.gni View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/ios/ios_sdk.gni View 1 2 1 chunk +1 line, -8 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 1 2 1 chunk +0 lines, -58 lines 0 comments Download
M build/toolchain/clang.gni View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M crypto/BUILD.gn View 1 2 3 3 chunks +5 lines, -10 lines 0 comments Download
M net/BUILD.gn View 1 2 3 3 chunks +10 lines, -14 lines 0 comments Download
M skia/BUILD.gn View 1 2 4 chunks +20 lines, -5 lines 1 comment Download
M skia/skia_gn_files.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/sqlite/BUILD.gn View 1 2 3 4 1 chunk +117 lines, -117 lines 0 comments Download
M tools/gn/secondary/chrome/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D tools/gn/secondary/net/BUILD.gn View 1 2 3 1 chunk +0 lines, -1221 lines 0 comments Download
M tools/gn/secondary/third_party/icu/BUILD.gn View 1 1 chunk +13 lines, -0 lines 0 comments Download
M tools/gn/secondary/third_party/libxml/BUILD.gn View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M tools/gn/secondary/third_party/nss/BUILD.gn View 3 chunks +18 lines, -4 lines 0 comments Download
M tools/gn/secondary/third_party/snappy/BUILD.gn View 1 2 1 chunk +10 lines, -18 lines 0 comments Download
M tools/gn/secondary/third_party/zlib/BUILD.gn View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_provider_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
Most of the mac build works but nspr doesn't link yet because GN ignores the ...
6 years, 8 months ago (2014-04-17 05:20:25 UTC) #1
scottmg
lgtm https://codereview.chromium.org/239543013/diff/60001/ui/events/gesture_detection/gesture_provider_unittest.cc File ui/events/gesture_detection/gesture_provider_unittest.cc (right): https://codereview.chromium.org/239543013/diff/60001/ui/events/gesture_detection/gesture_provider_unittest.cc#newcode113 ui/events/gesture_detection/gesture_provider_unittest.cc:113: EventType GetMostRecentGestureEventType() const { would be good to ...
6 years, 8 months ago (2014-04-17 18:20:45 UTC) #2
brettw
Committed patchset #5 manually as r264626.
6 years, 8 months ago (2014-04-17 20:36:47 UTC) #3
Nico
6 years, 5 months ago (2014-07-10 20:39:31 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/239543013/diff/80001/skia/BUILD.gn
File skia/BUILD.gn (right):

https://codereview.chromium.org/239543013/diff/80001/skia/BUILD.gn#newcode316
skia/BUILD.gn:316: #  SkASSERT(!"sk_out_of_memory");
They had fixed all these a while ago when I asked them to. They try to build
with "regular" warnings as far as I know. If that doesn't work in gn for some
reason, consider pinging mtklein or bungeman about it and they'll likely fix it
quickly.

Powered by Google App Engine
This is Rietveld 408576698