Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: build/config/compiler/BUILD.gn

Issue 239543013: Work on Mac GN build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix line endings Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index ac00477a8a6968200830b33d6078d10fbbe8f2b9..c492356ce6bfafb24a056e2f7a89e1e0a7fdff48 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -517,12 +517,8 @@ config("default_warnings") {
]
}
- # TODO(brettw) Ones below here should be clang-only when we have a flag
- # for it.
if (is_clang) {
cflags += [
- "-Wheader-hygiene",
-
# This warns on using ints as initializers for floats in
# initializer lists (e.g. |int a = f(); CGSize s = { a, a };|),
# which happens in several places in chrome code. Not sure if
@@ -545,9 +541,6 @@ config("default_warnings") {
# Clang spots more unused functions.
"-Wno-unused-function",
-
- # Warns when a const char[] is converted to bool.
- "-Wstring-conversion",
]
}
« no previous file with comments | « build/config/clang/BUILD.gn ('k') | build/config/crypto.gni » ('j') | skia/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698