Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: tools/gn/secondary/third_party/snappy/BUILD.gn

Issue 239543013: Work on Mac GN build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix line endings Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("snappy_config") { 5 config("snappy_config") {
6 include_dirs = [ 6 include_dirs = [
7 "src", 7 "src",
8 ] 8 ]
9 9
10 # These OS-specific generated headers were made by running the configure 10 # These OS-specific generated headers were made by running the configure
(...skipping 15 matching lines...) Expand all
26 "src/snappy-stubs-internal.cc", 26 "src/snappy-stubs-internal.cc",
27 "src/snappy-stubs-internal.h", 27 "src/snappy-stubs-internal.h",
28 "src/snappy.cc", 28 "src/snappy.cc",
29 "src/snappy.h", 29 "src/snappy.h",
30 ] 30 ]
31 31
32 configs -= [ "//build/config/compiler:chromium_code" ] 32 configs -= [ "//build/config/compiler:chromium_code" ]
33 configs += [ "//build/config/compiler:no_chromium_code" ] 33 configs += [ "//build/config/compiler:no_chromium_code" ]
34 direct_dependent_configs = [ ":snappy_config" ] 34 direct_dependent_configs = [ ":snappy_config" ]
35 35
36 #['OS=="win"', { 36 if (is_clang) {
37 # # Signed/unsigned comparison 37 # snappy-stubs-internal.h unapologetically has: using namespace std
38 # 'msvs_disabled_warnings': [ 38 # https://code.google.com/p/snappy/issues/detail?id=70
39 # # https://code.google.com/p/snappy/issues/detail?id=71 39 configs -= [ "//build/config/clang:extra_warnings" ]
40 # 4018, 40 }
41 # # https://code.google.com/p/snappy/issues/detail?id=75 41
42 # 4267, 42 if (is_win) {
43 # ], 43 # https://code.google.com/p/snappy/issues/detail?id=75
44 # }], 44 cflags = [ "/wd4267" ] # Conversion from size_t to 'type'.
45 # ['clang == 1', { 45 }
46 # # snappy-stubs-internal.h unapologetically has: using namespace std
47 # # https://code.google.com/p/snappy/issues/detail?id=70
48 # 'xcode_settings': {
49 # 'WARNING_CFLAGS!': [ '-Wheader-hygiene' ],
50 # },
51 # 'cflags!': [ '-Wheader-hygiene' ],
52 # }],
53 # ],
54 } 46 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698