Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/secondary/third_party/icu/BUILD.gn

Issue 239543013: Work on Mac GN build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix line endings Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« skia/BUILD.gn ('K') | « tools/gn/secondary/net/BUILD.gn ('k') | tools/gn/secondary/third_party/libxml/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/secondary/third_party/icu/BUILD.gn
diff --git a/tools/gn/secondary/third_party/icu/BUILD.gn b/tools/gn/secondary/third_party/icu/BUILD.gn
index fc9da5e745383deff8064b97aad3670cb663f694..21c4efa714b6b854bef44fbdd160b017865d1729 100644
--- a/tools/gn/secondary/third_party/icu/BUILD.gn
+++ b/tools/gn/secondary/third_party/icu/BUILD.gn
@@ -223,6 +223,19 @@ component("icui18n") {
configs += [ ":icu_code" ]
direct_dependent_configs = [ ":icu_config" ]
+
+ if (is_clang) {
+ # uspoof.h has a U_NAMESPACE_USE macro. That's a bug,
+ # the header should use U_NAMESPACE_BEGIN instead.
+ # http://bugs.icu-project.org/trac/ticket/9054
+ configs -= [ "//build/config/clang:extra_warnings" ]
+
+ cflags = [
+ "-Wno-header-hygiene",
+ # Looks like a real issue, see http://crbug.com/114660
+ "-Wno-return-type-c-linkage",
+ ]
+ }
}
component("icuuc") {
« skia/BUILD.gn ('K') | « tools/gn/secondary/net/BUILD.gn ('k') | tools/gn/secondary/third_party/libxml/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698