MD Settings: Migrating site_details_permission to native select.

MD Settings: Migrating site_details_permission to native select.

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/372b3d438b2d987cb0f9c82fb05c4941a37b4382
Cr-Commit-Position: refs/heads/master@{#423370}

[dpapad, 2016-10-05 17:40:25]

Description was changed from

==========
MD Settings: Migrating site_details_permission to native select.

BUG=651513
==========

to

==========
MD Settings: Migrating site_details_permission to native select.

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-10-05 18:09:23]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 18:10:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-10-05 18:12:30]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dpapad, 2016-10-05 18:12:47]

On 2016/10/05 at 18:12:31, dpapad wrote:
> 

After screenshot at http://imgur.com/a/csfZE.

[commit-bot: I haz the power, 2016-10-05 19:10:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 19:10:57]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-10-05 22:23:17]

LGTM with a tiny change.

https://codereview.chromium.org/2394923002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/site_details_permission_tests.js (right):

https://codereview.chromium.org/2394923002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/site_details_permission_tests.js:73: function
validatePermissionFlipWorks(origin, expectedPermissionValue) {
|expectedPermissionValue|, I like it!

https://codereview.chromium.org/2394923002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/site_details_permission_tests.js:150:
}).then(function(arguments) {
Let's remove the |arguments| arg (it's not used now).

[dpapad, 2016-10-05 22:41:47]

Thanks!

https://codereview.chromium.org/2394923002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/site_details_permission_tests.js (right):

https://codereview.chromium.org/2394923002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/settings/site_details_permission_tests.js:73: function
validatePermissionFlipWorks(origin, expectedPermissionValue) {
On 2016/10/05 at 22:23:17, dschuyler wrote:
> |expectedPermissionValue|, I like it!

Done. I also merged 4 calls to
"browserProxy.resetResolver('setCategoryPermissionForOrigin');" to a single
call.

[dpapad, 2016-10-05 22:43:47]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-10-05 22:43:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2394923002/#ps60001
(title: ""Nits."")

[commit-bot: I haz the power, 2016-10-05 22:44:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 01:07:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-06 01:10:28]

Description was changed from

==========
MD Settings: Migrating site_details_permission to native select.

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Migrating site_details_permission to native select.

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/372b3d438b2d987cb0f9c82fb05c4941a37b4382
Cr-Commit-Position: refs/heads/master@{#423370}
==========

[commit-bot: I haz the power, 2016-10-06 01:10:28]

Patchset 4 (id:??) landed as
https://crrev.com/372b3d438b2d987cb0f9c82fb05c4941a37b4382
Cr-Commit-Position: refs/heads/master@{#423370}