Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2395853002: MD Settings: Migrating site_data_details_dialog to native select. (Closed)

Created:
4 years, 2 months ago by dpapad
Modified:
4 years, 2 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Migrating site_data_details_dialog to native select. BUG=651513 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c564dca165c2e50ac104455ac3e2216b81ffe33a Cr-Commit-Position: refs/heads/master@{#423400}

Patch Set 1 : Nits #

Patch Set 2 : Nit. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -27 lines) Patch
M chrome/browser/resources/settings/site_settings/site_data_details_dialog.html View 1 1 chunk +13 lines, -21 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data_details_dialog.js View 1 4 chunks +7 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
dpapad
Before/after screenshots http://imgur.com/a/KDEu9.
4 years, 2 months ago (2016-10-05 19:17:59 UTC) #6
dschuyler
lgtm
4 years, 2 months ago (2016-10-05 22:16:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395853002/60001
4 years, 2 months ago (2016-10-06 01:11:11 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 2 months ago (2016-10-06 02:24:15 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 02:25:44 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c564dca165c2e50ac104455ac3e2216b81ffe33a
Cr-Commit-Position: refs/heads/master@{#423400}

Powered by Google App Engine
This is Rietveld 408576698