Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: chrome/test/data/webui/settings/site_details_permission_tests.js

Issue 2394923002: MD Settings: Migrating site_details_permission to native select. (Closed)
Patch Set: "Nits." Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_details_permission.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/site_details_permission_tests.js
diff --git a/chrome/test/data/webui/settings/site_details_permission_tests.js b/chrome/test/data/webui/settings/site_details_permission_tests.js
index be6276338aa6d846fcb0d7dca9f803bbed653712..b56bd19df42b893d059293993067d21a9a6b4a87 100644
--- a/chrome/test/data/webui/settings/site_details_permission_tests.js
+++ b/chrome/test/data/webui/settings/site_details_permission_tests.js
@@ -70,16 +70,19 @@ cr.define('site_details_permission', function() {
return false;
};
- function validatePermissionFlipWorks(origin, allow) {
- MockInteractions.tap(allow ? testElement.$.allow : testElement.$.block);
+ function validatePermissionFlipWorks(origin, expectedPermissionValue) {
+ browserProxy.resetResolver('setCategoryPermissionForOrigin');
+
+ // Simulate permission change initiated by the user.
+ testElement.$.permission.value = expectedPermissionValue;
+ testElement.$.permission.dispatchEvent(new CustomEvent('change'));
+
return browserProxy.whenCalled('setCategoryPermissionForOrigin').then(
- function(arguments) {
- assertEquals(origin, arguments[0]);
- assertEquals('', arguments[1]);
- assertEquals(testElement.category, arguments[2]);
- assertEquals(allow ?
- settings.PermissionValues.ALLOW :
- settings.PermissionValues.BLOCK, arguments[3]);
+ function(args) {
+ assertEquals(origin, args[0]);
+ assertEquals('', args[1]);
+ assertEquals(testElement.category, args[2]);
+ assertEquals(expectedPermissionValue, args[3]);
});
};
@@ -114,13 +117,14 @@ cr.define('site_details_permission', function() {
'Widget should be labelled correctly');
// Flip the permission and validate that prefs stay in sync.
- return validatePermissionFlipWorks(origin, true);
+ return validatePermissionFlipWorks(
+ origin, settings.PermissionValues.ALLOW);
}).then(function() {
- browserProxy.resetResolver('setCategoryPermissionForOrigin');
- return validatePermissionFlipWorks(origin, false);
+ return validatePermissionFlipWorks(
+ origin, settings.PermissionValues.BLOCK);
}).then(function() {
- browserProxy.resetResolver('setCategoryPermissionForOrigin');
- return validatePermissionFlipWorks(origin, true);
+ return validatePermissionFlipWorks(
+ origin, settings.PermissionValues.ALLOW);
});
});
@@ -141,19 +145,15 @@ cr.define('site_details_permission', function() {
assertEquals('Cookies', header.innerText.trim(),
'Widget should be labelled correctly');
- MockInteractions.tap(testElement.$.sessionOnly);
- return browserProxy.whenCalled('setCategoryPermissionForOrigin');
- }).then(function(arguments) {
- assertEquals(origin, arguments[0]);
- assertEquals('', arguments[1]);
- assertEquals(testElement.category, arguments[2]);
- assertEquals(settings.PermissionValues.SESSION_ONLY, arguments[3]);
+ return validatePermissionFlipWorks(
+ origin, settings.PermissionValues.SESSION_ONLY);
+ }).then(function() {
// Flip the permission and validate that prefs stay in sync.
- browserProxy.resetResolver('setCategoryPermissionForOrigin');
- return validatePermissionFlipWorks(origin, true);
+ return validatePermissionFlipWorks(
+ origin, settings.PermissionValues.ALLOW);
}).then(function() {
- browserProxy.resetResolver('setCategoryPermissionForOrigin');
- return validatePermissionFlipWorks(origin, false);
+ return validatePermissionFlipWorks(
+ origin, settings.PermissionValues.BLOCK);
});
});
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_details_permission.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698