Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/browser/resources/settings/site_settings/site_details_permission.js

Issue 2394923002: MD Settings: Migrating site_details_permission to native select. (Closed)
Patch Set: "Nits." Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_details_permission.js
diff --git a/chrome/browser/resources/settings/site_settings/site_details_permission.js b/chrome/browser/resources/settings/site_settings/site_details_permission.js
index 604eba3a2661e0842234f8eac17c89249b5f0b47..3408b6fa2edb88212a077d9df5c98575a57e5592 100644
--- a/chrome/browser/resources/settings/site_settings/site_details_permission.js
+++ b/chrome/browser/resources/settings/site_settings/site_details_permission.js
@@ -59,7 +59,7 @@ Polymer({
for (var i = 0; i < exceptionList.length; ++i) {
if (exceptionList[i].embeddingOrigin == site.embeddingOrigin &&
this.sameOrigin_(exceptionList[i].origin, site.origin)) {
- this.$.permission.selected = exceptionList[i].setting;
+ this.$.permission.value = exceptionList[i].setting;
this.$.details.hidden = false;
break;
}
@@ -99,12 +99,11 @@ Polymer({
/**
* Handles the category permission changing for this origin.
- * @param {!{detail: !{item: !{dataset: !{permissionValue: string}}}}} event
+ * @private
*/
- onPermissionMenuIronActivate_: function(event) {
- var value = event.detail.item.dataset.permissionValue;
+ onPermissionSelectionChange_: function() {
this.browserProxy.setCategoryPermissionForOrigin(
- this.site.origin, this.site.embeddingOrigin, this.category, value,
- this.site.incognito);
+ this.site.origin, this.site.embeddingOrigin, this.category,
+ this.$.permission.value, this.site.incognito);
},
});

Powered by Google App Engine
This is Rietveld 408576698