Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2394343002: Removing ShouldSwapProcessesForRedirect (using DoesSiteRequireDedicatedProcess).

Created:
4 years, 2 months ago by Łukasz Anforowicz
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, tzik, tburkard+watch_chromium.org, kinuko+watch, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jam, darin-cc_chromium.org, loading-reviews_chromium.org, chromium-apps-reviews_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, jsbell+serviceworker_chromium.org, Peter Beverloo, Randy Smith (Not in Mondays), nhiroki, gavinp+prer_chromium.org, jochen+watch_chromium.org, michaeln, shimazu+serviceworker_chromium.org, serviceworker-reviews, kinuko+serviceworker, horo+watch_chromium.org, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing ShouldSwapProcessesForRedirect (using DoesSiteRequireDedicatedProcess). ShouldSwapProcessesForRedirect is not needed anymore: 1. In PlzNavigate mode transfers are only happening *after* all the redirects. 2. For --isolate-extensions and other isolation modes, the renderer process needs to be selected based on *final* destination. This CL removes ShouldSwapProcessesForRedirect. DoesSiteRequireDedicatedProcess is used in tests that want to force a process swap. BUG=655214 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -148 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 2 chunks +0 lines, -63 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 chunks +9 lines, -10 lines 0 comments Download
M content/browser/cross_site_transfer_browsertest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 2 1 chunk +5 lines, -13 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 2 4 chunks +6 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (8 generated)
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-06 21:42:07 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2394343002/1
4 years, 2 months ago (2016-10-06 21:42:49 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-06 22:13:53 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/237659)
4 years, 2 months ago (2016-10-06 22:13:54 UTC) #4
Łukasz Anforowicz
Description was changed from ========== Removing ShouldSwapProcessesForRedirect (using DoesSiteRequireDedicatedProcess). BUG= ========== to ========== Removing ShouldSwapProcessesForRedirect ...
3 years, 7 months ago (2017-05-08 17:23:17 UTC) #5
Łukasz Anforowicz
Description was changed from ========== Removing ShouldSwapProcessesForRedirect (using DoesSiteRequireDedicatedProcess). ShouldSwapProcessesForRedirect is not needed anymore: 1. ...
3 years, 7 months ago (2017-05-08 17:25:42 UTC) #6
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 17:25:51 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 17:26:12 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698