Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2160)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 2394343002: Removing ShouldSwapProcessesForRedirect (using DoesSiteRequireDedicatedProcess).
Patch Set: Rebasing... Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index 3fb3cf44336a173d24de353b9eeebf7f1ae89186..2fe7ab6a2e569646fa292278dcb106a26d238c98 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -512,24 +512,6 @@ class TestContentBrowserClient : public ChromeContentBrowserClient {
DISALLOW_COPY_AND_ASSIGN(TestContentBrowserClient);
};
-// A ContentBrowserClient that forces cross-process navigations.
-class SwapProcessesContentBrowserClient : public ChromeContentBrowserClient {
- public:
- SwapProcessesContentBrowserClient() {}
- ~SwapProcessesContentBrowserClient() override {}
-
- // ChromeContentBrowserClient:
- bool ShouldSwapProcessesForRedirect(
- content::BrowserContext* browser_context,
- const GURL& current_url,
- const GURL& new_url) override {
- return true;
- }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(SwapProcessesContentBrowserClient);
-};
-
base::FilePath GetTestPath(const std::string& file_name) {
return ui_test_utils::GetTestFilePath(
base::FilePath(FILE_PATH_LITERAL("prerender")),
@@ -2948,51 +2930,6 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderCapturedWebContents) {
}
// Checks that prerenders are aborted on cross-process navigation from
-// a server redirect.
-IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
- PrerenderCrossProcessServerRedirect) {
- // Cross-process navigations don't happen for prerendering with PlzNavigate,
- // since we decide on a process after redirects are followed.
- if (content::IsBrowserSideNavigationEnabled())
- return;
-
- // Force everything to be a process swap.
- SwapProcessesContentBrowserClient test_browser_client;
- content::ContentBrowserClient* original_browser_client =
- content::SetBrowserClientForTesting(&test_browser_client);
-
- PrerenderTestURL(CreateServerRedirect("/prerender/prerender_page.html"),
- FINAL_STATUS_OPEN_URL, 0);
-
- content::SetBrowserClientForTesting(original_browser_client);
-}
-
-// Checks that URLRequests for prerenders being aborted on cross-process
-// navigation from a server redirect are cleaned up, so they don't keep cache
-// entries locked.
-// See http://crbug.com/341134
-IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
- PrerenderCrossProcessServerRedirectNoHang) {
- // Cross-process navigations don't happen for prerendering with PlzNavigate,
- // since we decide on a process after redirects are followed.
- if (content::IsBrowserSideNavigationEnabled())
- return;
-
- const char kDestPath[] = "/prerender/prerender_page.html";
- // Force everything to be a process swap.
- SwapProcessesContentBrowserClient test_browser_client;
- content::ContentBrowserClient* original_browser_client =
- content::SetBrowserClientForTesting(&test_browser_client);
-
- PrerenderTestURL(CreateServerRedirect(kDestPath), FINAL_STATUS_OPEN_URL, 0);
-
- ui_test_utils::NavigateToURL(browser(),
- embedded_test_server()->GetURL(kDestPath));
-
- content::SetBrowserClientForTesting(original_browser_client);
-}
-
-// Checks that prerenders are aborted on cross-process navigation from
// a client redirect.
IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
PrerenderCrossProcessClientRedirect) {
« no previous file with comments | « chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698