Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2394343002: Removing ShouldSwapProcessesForRedirect (using DoesSiteRequireDedicatedProcess).
Patch Set: Rebasing... Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index c4524a8a7c3e821dcff3c9d33ec625071afdc5bc..f77a789fe061a56f9547939c62d37297c3d84273 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -915,21 +915,13 @@ bool NavigationHandleImpl::MaybeTransferAndProceedInternal() {
return true;
}
- // The content embedder can decide that a transfer to a different process is
- // required for this URL.
- bool should_transfer =
- GetContentClient()->browser()->ShouldSwapProcessesForRedirect(
- frame_tree_node_->navigator()->GetController()->GetBrowserContext(),
- original_url_, url_);
-
- RenderFrameHostManager* manager =
- render_frame_host_->frame_tree_node()->render_manager();
-
- // In the site-per-process model, the RenderFrameHostManager may also decide
- // (independently from the content embedder's ShouldSwapProcessesForRedirect
- // above) that a process transfer is needed. Process transfers are skipped for
+ // In the site-per-process model, the RenderFrameHostManager may decide
+ // that a process transfer is needed. Process transfers are skipped for
// WebUI processes for now, since e.g. chrome://settings has multiple
// "cross-site" chrome:// frames, and that doesn't yet work cross-process.
+ bool should_transfer = false;
+ RenderFrameHostManager* manager =
+ render_frame_host_->frame_tree_node()->render_manager();
if (SiteIsolationPolicy::AreCrossProcessFramesPossible() &&
!ChildProcessSecurityPolicyImpl::GetInstance()->HasWebUIBindings(
render_frame_host_->GetProcess()->GetID())) {
« no previous file with comments | « content/browser/cross_site_transfer_browsertest.cc ('k') | content/browser/loader/resource_dispatcher_host_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698