Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2386503002: With --isolate-extensions, forking (via OpenURL) for extensions is not needed.

Created:
4 years, 2 months ago by Łukasz Anforowicz
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

With --isolate-extensions, forking (via OpenURL) for extensions is not needed. In --isolate-extensions mode, all navigations involving extensions should correctly isolate extensions into renderer processes, even without going through ShouldFork / OpenURL path. Avoiding ShouldFork for extensions also allows to remove the exception in ChromeContentRendererClient::ShouldFork for http POST method. BUG=650694

Patch Set 1 #

Patch Set 2 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -186 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 1 5 chunks +64 lines, -49 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extension_web_contents_observer.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/process_management_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/process_manager_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/site_details_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/common/extensions/extension_process_policy.h View 1 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/common/extensions/extension_process_policy.cc View 1 1 chunk +0 lines, -68 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_renderer_client.cc View 1 8 chunks +80 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (10 generated)
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-09-29 22:45:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386503002/1
4 years, 2 months ago (2016-09-29 22:45:49 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-09-29 23:28:51 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/286952)
4 years, 2 months ago (2016-09-29 23:28:52 UTC) #4
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 18:14:14 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386503002/1
3 years, 7 months ago (2017-05-08 18:15:13 UTC) #6
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-08 18:16:07 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386503002/20001
3 years, 7 months ago (2017-05-08 18:17:21 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-08 19:41:45 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 19:41:46 UTC) #10 
Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698