Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2393313002: reflow comments in core/frame (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, mlamouri+watch-blink_chromium.org, timvolodine, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in core/frame BUG=563793 Committed: https://crrev.com/a6508ca00c122034df41b20985aee9b6b892ddd2 Cr-Commit-Position: refs/heads/master@{#423449}

Patch Set 1 #

Total comments: 4

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+722 lines, -493 lines) Patch
M third_party/WebKit/Source/core/frame/DOMTimer.h View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 7 chunks +20 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindowProperty.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.h View 4 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 4 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.h View 2 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.h View 2 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.cpp View 1 5 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 25 chunks +101 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 67 chunks +202 lines, -138 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameViewAutoSizeInfo.cpp View 4 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/History.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 6 chunks +18 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 15 chunks +39 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 4 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 8 chunks +25 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Location.h View 2 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Location.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Navigator.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/PlatformEventController.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/PlatformEventDispatcher.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.cpp View 5 chunks +15 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewportTest.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/SmartClip.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/TopControls.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 3 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 7 chunks +16 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounterTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.h View 4 chunks +13 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 7 chunks +18 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 7 chunks +18 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSourceList.cpp View 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSourceListTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h View 6 chunks +16 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 14 chunks +47 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Nico
4 years, 2 months ago (2016-10-05 21:47:31 UTC) #4
Nico
On 2016/10/05 21:47:31, Nico wrote: dcheng: ping
4 years, 2 months ago (2016-10-06 01:49:09 UTC) #7
dcheng
LGTM https://codereview.chromium.org/2393313002/diff/1/third_party/WebKit/Source/core/frame/FrameView.cpp File third_party/WebKit/Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/2393313002/diff/1/third_party/WebKit/Source/core/frame/FrameView.cpp#newcode2212 third_party/WebKit/Source/core/frame/FrameView.cpp:2212: // of the highest-level layout() call. Nit: own ...
4 years, 2 months ago (2016-10-06 02:43:13 UTC) #8
Nico
https://codereview.chromium.org/2393313002/diff/1/third_party/WebKit/Source/core/frame/FrameView.cpp File third_party/WebKit/Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/2393313002/diff/1/third_party/WebKit/Source/core/frame/FrameView.cpp#newcode2212 third_party/WebKit/Source/core/frame/FrameView.cpp:2212: // of the highest-level layout() call. On 2016/10/06 02:43:13, ...
4 years, 2 months ago (2016-10-06 03:22:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393313002/20001
4 years, 2 months ago (2016-10-06 03:22:39 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 06:22:57 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 06:26:10 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a6508ca00c122034df41b20985aee9b6b892ddd2
Cr-Commit-Position: refs/heads/master@{#423449}

Powered by Google App Engine
This is Rietveld 408576698