third_party/WebKit/Source/core/frame/History.cpp - Issue 2393313002: reflow comments in core/frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/History.cpp

Issue 2393313002: reflow comments in core/frame (Closed)

Patch Set: tweak Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameViewAutoSizeInfo.cpp ('k') | third_party/WebKit/Source/core/frame/ImageBitmap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/History.cpp

diff --git a/third_party/WebKit/Source/core/frame/History.cpp b/third_party/WebKit/Source/core/frame/History.cpp

index a3b323742d5683a1d2d3288ed5d4646a52af8bd6..ff278e4d8c74cc3ff2685cc5e9a663d3f5dd44c4 100644

--- a/third_party/WebKit/Source/core/frame/History.cpp

+++ b/third_party/WebKit/Source/core/frame/History.cpp

@@ -203,7 +203,9 @@ void History::stateObjectAdded(PassRefPtr<SerializedScriptValue> data,

KURL fullURL = urlForState(urlString);

if (!canChangeToUrl(fullURL, frame()->document()->getSecurityOrigin(),

frame()->document()->url())) {

- // We can safely expose the URL to JavaScript, as a) no redirection takes place: JavaScript already had this URL, b) JavaScript can only access a same-origin History object.

+ // We can safely expose the URL to JavaScript, as a) no redirection takes

+ // place: JavaScript already had this URL, b) JavaScript can only access a

+ // same-origin History object.

exceptionState.throwSecurityError(

"A history state object with URL '" + fullURL.elidedString() +

"' cannot be created in a document with origin '" +