Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: third_party/WebKit/Source/core/frame/ImageBitmap.cpp

Issue 2393313002: reflow comments in core/frame (Closed)
Patch Set: tweak Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/ImageBitmap.cpp
diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
index 7ca36d26e540579df8fa793a2a551a83829cddc2..2aa2786cb88392398151b6b5d09150bb129d6be7 100644
--- a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
@@ -31,8 +31,9 @@ struct ParsedOptions {
unsigned resizeHeight = 0;
IntRect cropRect;
SkFilterQuality resizeQuality = kLow_SkFilterQuality;
- // This value should be changed in the future when we support createImageBitmap with higher
- // bit depth, in the parseOptions() function. For now, it is always 4.
+ // This value should be changed in the future when we support
+ // createImageBitmap with higher bit depth, in the parseOptions() function.
+ // For now, it is always 4.
int bytesPerPixel = 4;
};
@@ -128,9 +129,9 @@ bool dstBufferSizeHasOverflow(ParsedOptions options) {
static PassRefPtr<Uint8Array> copySkImageData(SkImage* input,
const SkImageInfo& info) {
- // The function dstBufferSizeHasOverflow() is being called at the beginning of each
- // ImageBitmap() constructor, which makes sure that doing width * height * bytesPerPixel
- // will never overflow size_t.
+ // The function dstBufferSizeHasOverflow() is being called at the beginning of
+ // each ImageBitmap() constructor, which makes sure that doing
+ // width * height * bytesPerPixel will never overflow size_t.
size_t width = static_cast<size_t>(input->width());
RefPtr<ArrayBuffer> dstBuffer =
ArrayBuffer::createOrNull(width * input->height(), info.bytesPerPixel());
@@ -266,10 +267,11 @@ bool ImageBitmap::isSourceSizeValid(int sourceWidth,
return true;
}
-// The parameter imageFormat indicates whether the first parameter "image" is unpremultiplied or not.
-// imageFormat = PremultiplyAlpha means the image is in premuliplied format
-// For example, if the image is already in unpremultiplied format and we want the created ImageBitmap
-// in the same format, then we don't need to use the ImageDecoder to decode the image.
+// The parameter imageFormat indicates whether the first parameter "image" is
+// unpremultiplied or not. imageFormat = PremultiplyAlpha means the image is in
+// premuliplied format For example, if the image is already in unpremultiplied
+// format and we want the created ImageBitmap in the same format, then we don't
+// need to use the ImageDecoder to decode the image.
static PassRefPtr<StaticBitmapImage> cropImage(
Image* image,
const ParsedOptions& parsedOptions,
@@ -280,8 +282,9 @@ static PassRefPtr<StaticBitmapImage> cropImage(
IntRect imgRect(IntPoint(), IntSize(image->width(), image->height()));
const IntRect srcRect = intersection(imgRect, parsedOptions.cropRect);
- // In the case when cropRect doesn't intersect the source image and it requires a umpremul image
- // We immediately return a transparent black image with cropRect.size()
+ // In the case when cropRect doesn't intersect the source image and it
+ // requires a umpremul image We immediately return a transparent black image
+ // with cropRect.size()
if (srcRect.isEmpty() && !parsedOptions.premultiplyAlpha) {
SkImageInfo info =
SkImageInfo::Make(parsedOptions.resizeWidth, parsedOptions.resizeHeight,
@@ -299,7 +302,8 @@ static PassRefPtr<StaticBitmapImage> cropImage(
}
sk_sp<SkImage> skiaImage = image->imageForCurrentFrame();
- // Attempt to get raw unpremultiplied image data, executed only when skiaImage is premultiplied.
+ // Attempt to get raw unpremultiplied image data, executed only when skiaImage
+ // is premultiplied.
if ((((!parsedOptions.premultiplyAlpha && !skiaImage->isOpaque()) ||
!skiaImage) &&
image->data() && imageFormat == PremultiplyAlpha) ||
@@ -323,7 +327,8 @@ static PassRefPtr<StaticBitmapImage> cropImage(
croppedSkImage.get(), parsedOptions.premultiplyAlpha
? PremultiplyAlpha
: DontPremultiplyAlpha));
- // Special case: The first parameter image is unpremul but we need to turn it into premul.
+ // Special case: The first parameter image is unpremul but we need to turn
+ // it into premul.
if (parsedOptions.premultiplyAlpha && imageFormat == DontPremultiplyAlpha)
return StaticBitmapImage::create(
unPremulSkImageToPremul(croppedSkImage.get()));
« no previous file with comments | « third_party/WebKit/Source/core/frame/ImageBitmap.h ('k') | third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698