Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2392823002: Remove create[Done|UnexpectedError]DataConsumerHandle (Closed)

Created:
4 years, 2 months ago by yhirano
Modified:
4 years, 2 months ago
Reviewers:
hiroshige
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove create[Done|UnexpectedError]DataConsumerHandle This CL replaces createDoneDataConsumerHandle and createUnexpecteErrorDataConsumerHandle with BytesConsumer::createDone and BytesConsumer::createErrored respectively. This CL also makes BodyStreamBuffer update its status synchronously at the construction time. This CL also removes a BodyStreamBuffer constructor that takes a FetchDataConsumerHandle. BUG=610195 Committed: https://crrev.com/f745c3d8e43f2153da3976e837323cb414f9e414 Cr-Commit-Position: refs/heads/master@{#422742}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -268 lines) Patch
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 1 4 chunks +3 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 13 chunks +41 lines, -66 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumer.cpp View 2 chunks +56 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumerTest.cpp View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtil.h View 1 2 2 chunks +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtil.cpp View 3 chunks +0 lines, -76 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp View 2 chunks +0 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Request.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ResponseTest.cpp View 1 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
yhirano
4 years, 2 months ago (2016-10-04 06:59:00 UTC) #13
hiroshige
On 2016/10/04 06:59:00, yhirano wrote: lgtm.
4 years, 2 months ago (2016-10-04 09:58:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392823002/60001
4 years, 2 months ago (2016-10-04 10:15:20 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-04 10:20:32 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 10:23:04 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f745c3d8e43f2153da3976e837323cb414f9e414
Cr-Commit-Position: refs/heads/master@{#422742}

Powered by Google App Engine
This is Rietveld 408576698