Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp

Issue 2392823002: Remove create[Done|UnexpectedError]DataConsumerHandle (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp
index d0e4735dcabe9339c0d651be9596d2c78c8b3bd2..c26fdedea0ccc669e8895c632785ad7f4408c7cf 100644
--- a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtilTest.cpp
@@ -13,7 +13,6 @@ namespace {
const WebDataConsumerHandle::Result kShouldWait =
WebDataConsumerHandle::ShouldWait;
-const WebDataConsumerHandle::Result kDone = WebDataConsumerHandle::Done;
const WebDataConsumerHandle::Result kUnexpectedError =
WebDataConsumerHandle::UnexpectedError;
const WebDataConsumerHandle::Flags kNone = WebDataConsumerHandle::FlagNone;
@@ -39,63 +38,6 @@ TEST(DataConsumerHandleUtilTest, WaitingHandleNoNotification) {
test->run(createWaitingDataConsumerHandle());
}
-TEST(DataConsumerHandleUtilTest, CreateDoneHandle) {
- char buffer[20];
- const void* p = nullptr;
- size_t size = 0;
- std::unique_ptr<WebDataConsumerHandle> handle =
- createDoneDataConsumerHandle();
- std::unique_ptr<WebDataConsumerHandle::Reader> reader =
- handle->obtainReader(nullptr);
-
- EXPECT_EQ(kDone, reader->read(buffer, sizeof(buffer), kNone, &size));
- EXPECT_EQ(kDone, reader->beginRead(&p, kNone, &size));
- EXPECT_EQ(kUnexpectedError, reader->endRead(99));
-}
-
-TEST(DataConsumerHandleUtilTest, DoneHandleNotification) {
- RefPtr<DataConsumerHandleTestUtil::ThreadingHandleNotificationTest> test =
- DataConsumerHandleTestUtil::ThreadingHandleNotificationTest::create();
- // Test this function returns.
- test->run(createDoneDataConsumerHandle());
-}
-
-TEST(DataConsumerHandleUtilTest, DoneHandleNoNotification) {
- RefPtr<DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest> test =
- DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest::create();
- // Test this function doesn't crash.
- test->run(createDoneDataConsumerHandle());
-}
-
-TEST(DataConsumerHandleUtilTest, CreateUnexpectedErrorHandle) {
- char buffer[20];
- const void* p = nullptr;
- size_t size = 0;
- std::unique_ptr<WebDataConsumerHandle> handle =
- createUnexpectedErrorDataConsumerHandle();
- std::unique_ptr<WebDataConsumerHandle::Reader> reader =
- handle->obtainReader(nullptr);
-
- EXPECT_EQ(kUnexpectedError,
- reader->read(buffer, sizeof(buffer), kNone, &size));
- EXPECT_EQ(kUnexpectedError, reader->beginRead(&p, kNone, &size));
- EXPECT_EQ(kUnexpectedError, reader->endRead(99));
-}
-
-TEST(DataConsumerHandleUtilTest, UnexpectedErrorHandleNotification) {
- RefPtr<DataConsumerHandleTestUtil::ThreadingHandleNotificationTest> test =
- DataConsumerHandleTestUtil::ThreadingHandleNotificationTest::create();
- // Test this function returns.
- test->run(createUnexpectedErrorDataConsumerHandle());
-}
-
-TEST(DataConsumerHandleUtilTest, UnexpectedErrorHandleNoNotification) {
- RefPtr<DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest> test =
- DataConsumerHandleTestUtil::ThreadingHandleNoNotificationTest::create();
- // Test this function doesn't crash.
- test->run(createUnexpectedErrorDataConsumerHandle());
-}
-
} // namespace
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698