Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: third_party/WebKit/Source/modules/fetch/BytesConsumerTest.cpp

Issue 2392823002: Remove create[Done|UnexpectedError]DataConsumerHandle (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/BytesConsumerTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/BytesConsumerTest.cpp b/third_party/WebKit/Source/modules/fetch/BytesConsumerTest.cpp
index 47ad1ac5a730d3a4b2a34d0f8f557a509376a331..d05d7beed6e48534f913215651e4779d5fc7ed07 100644
--- a/third_party/WebKit/Source/modules/fetch/BytesConsumerTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/BytesConsumerTest.cpp
@@ -408,6 +408,29 @@ TEST_F(BytesConsumerTeeTest,
EXPECT_EQ(BytesConsumer::PublicState::Closed, dest1->getPublicState());
}
+TEST(BytesConusmerTest, ClosedBytesConsumer) {
+ BytesConsumer* consumer = BytesConsumer::createClosed();
+
+ const char* buffer = nullptr;
+ size_t available = 0;
+ EXPECT_EQ(Result::Done, consumer->beginRead(&buffer, &available));
+ EXPECT_EQ(BytesConsumer::PublicState::Closed, consumer->getPublicState());
+}
+
+TEST(BytesConusmerTest, ErroredBytesConsumer) {
+ BytesConsumer::Error error("hello");
+ BytesConsumer* consumer = BytesConsumer::createErrored(error);
+
+ const char* buffer = nullptr;
+ size_t available = 0;
+ EXPECT_EQ(Result::Error, consumer->beginRead(&buffer, &available));
+ EXPECT_EQ(BytesConsumer::PublicState::Errored, consumer->getPublicState());
+ EXPECT_EQ(error.message(), consumer->getError().message());
+
+ consumer->cancel();
+ EXPECT_EQ(BytesConsumer::PublicState::Errored, consumer->getPublicState());
+}
+
} // namespace
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698