Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 2392823002: Remove create[Done|UnexpectedError]DataConsumerHandle (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/FetchManager.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
index e19a2cccd33ac0cb0fd6ed01cc8c3d6dcec318a5..9232798c8b3d0f768d713b3f6961d2174c1a7a17 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
+++ b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
@@ -233,10 +233,8 @@ class FetchManager::Loader final
return;
}
}
- m_updater->update(new BytesConsumerForDataConsumerHandle(
- m_response->getExecutionContext(),
- createFetchDataConsumerHandleFromWebHandle(
- createUnexpectedErrorDataConsumerHandle())));
+ m_updater->update(
+ BytesConsumer::createErrored(BytesConsumer::Error(errorMessage)));
m_loader->performNetworkError(errorMessage);
}
@@ -419,7 +417,9 @@ void FetchManager::Loader::didReceiveResponse(
if (m_request->integrity().isEmpty()) {
responseData = FetchResponseData::createWithBuffer(new BodyStreamBuffer(
scriptState,
- createFetchDataConsumerHandleFromWebHandle(std::move(handle))));
+ new BytesConsumerForDataConsumerHandle(
+ scriptState->getExecutionContext(),
+ createFetchDataConsumerHandleFromWebHandle(std::move(handle)))));
} else {
sriConsumer = new SRIBytesConsumer();
responseData = FetchResponseData::createWithBuffer(

Powered by Google App Engine
This is Rietveld 408576698