Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2392443007: reflow comments in modules/[app_banner,encoding] (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
haraken, dcheng
CC:
chromium-reviews, dominickn+watch_chromium.org, Peter Beverloo, mlamouri+watch-blink_chromium.org, iclelland+watch_chromium.org, chasej+watch_chromium.org, timvolodine, scheib+watch_chromium.org, pkotwicz+watch_chromium.org, jkarlin+watch_chromium.org, blink-reviews, ortuno+watch_chromium.org, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in modules/[app_banner,encoding] BUG=563793 TBR=haraken Committed: https://crrev.com/16c0fd8db8d05c48e4f4972a494d49c84917276d Cr-Commit-Position: refs/heads/master@{#423026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -79 lines) Patch
M third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/background_sync/SyncCallbacks.h View 2 chunks +16 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/background_sync/SyncManager.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp View 6 chunks +14 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/Credential.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/CredentialManagerClient.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/crypto/SubtleCrypto.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/crypto/SubtleCrypto.cpp View 13 chunks +26 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/device_light/DeviceLightDispatcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceMotionDispatcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationAbsoluteController.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationDispatcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encoding/Encoding.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encoding/TextDecoder.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Nico
dcheng: review haraken: owners
4 years, 2 months ago (2016-10-04 19:22:55 UTC) #2
dcheng
lgtm
4 years, 2 months ago (2016-10-04 21:50:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392443007/1
4 years, 2 months ago (2016-10-04 23:00:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 00:45:44 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/16c0fd8db8d05c48e4f4972a494d49c84917276d Cr-Commit-Position: refs/heads/master@{#423026}
4 years, 2 months ago (2016-10-05 00:52:56 UTC) #10
haraken
4 years, 2 months ago (2016-10-05 00:59:54 UTC) #11
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698