third_party/WebKit/Source/modules/background_sync/SyncManager.cpp - Issue 2392443007: reflow comments in modules/[app_banner,encoding]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

Issue 2392443007: reflow comments in modules/[app_banner,encoding] (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

diff --git a/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp b/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

index 0abc6d1072523455e6cd2620f366e7343018ee05..9711c0060e47bbbb47379e5e0856d9fe47721a01 100644

--- a/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

+++ b/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp

@@ -37,7 +37,8 @@ SyncManager::SyncManager(ServiceWorkerRegistration* registration)

ScriptPromise SyncManager::registerFunction(ScriptState* scriptState,

ExecutionContext* context,

const String& tag) {

- // TODO(jkarlin): Wait for the registration to become active instead of rejecting. See crbug.com/542437.

+ // TODO(jkarlin): Wait for the registration to become active instead of

+ // rejecting. See crbug.com/542437.

if (!m_registration->active())

return ScriptPromise::rejectWithDOMException(

scriptState,