| Index: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
|
| diff --git a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
|
| index 315b21c9188292bcb174741f0d25b28dfa801247..bdbee8efa943be4f6e480785d8f881ead72963a6 100644
|
| --- a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
|
| +++ b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
|
| @@ -167,11 +167,12 @@ ScriptPromise CredentialsContainer::get(
|
|
|
| Vector<KURL> providers;
|
| if (options.hasFederated() && options.federated().hasProviders()) {
|
| - // TODO(mkwst): CredentialRequestOptions::federated() needs to return a reference, not a value.
|
| - // Because it returns a temporary value now, a for loop that directly references the value
|
| - // generates code that holds a reference to a value that no longer exists by the time the loop
|
| - // starts looping. In order to avoid this crazyness for the moment, we're making a copy of the
|
| - // vector. https://crbug.com/587088
|
| + // TODO(mkwst): CredentialRequestOptions::federated() needs to return a
|
| + // reference, not a value. Because it returns a temporary value now, a for
|
| + // loop that directly references the value generates code that holds a
|
| + // reference to a value that no longer exists by the time the loop starts
|
| + // looping. In order to avoid this crazyness for the moment, we're making a
|
| + // copy of the vector. https://crbug.com/587088
|
| const Vector<String> providerStrings = options.federated().providers();
|
| for (const auto& string : providerStrings) {
|
| KURL url = KURL(KURL(), string);
|
|
|