third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp - Issue 2392443007: reflow comments in modules/[app_banner,encoding]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

Issue 2392443007: reflow comments in modules/[app_banner,encoding] (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h ('k') | third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

diff --git a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

index f738d6acc5f12c7b27ca15b802dda453a68ad247..ed79cfe61ff52871a165ef77b80ba56e2b4ca8f9 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

+++ b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

@@ -88,8 +88,9 @@ PasswordCredential* PasswordCredential::create(HTMLFormElement* form,

return nullptr;

ASSERT(credential);

- // After creating the Credential, populate its 'additionalData', 'idName', and 'passwordName' attributes.

- // If the form's 'enctype' is anything other than multipart, generate a URLSearchParams using the

+ // After creating the Credential, populate its 'additionalData', 'idName', and

+ // 'passwordName' attributes. If the form's 'enctype' is anything other than

+ // multipart, generate a URLSearchParams using the

// data in |formData|.

credential->setIdName(idName);

credential->setPasswordName(passwordName);

@@ -128,7 +129,8 @@ PasswordCredential::PasswordCredential(const String& id,

PassRefPtr<EncodedFormData> PasswordCredential::encodeFormData(

String& contentType) const {

if (m_additionalData.isURLSearchParams()) {

- // If |additionalData| is a 'URLSearchParams' object, build a urlencoded response.

+ // If |additionalData| is a 'URLSearchParams' object, build a urlencoded

+ // response.

URLSearchParams* params = URLSearchParams::create(URLSearchParamsInit());

URLSearchParams* additionalData = m_additionalData.getAsURLSearchParams();

for (const auto& param : additionalData->params()) {