Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2391943002: Rewrap comments to 80 columns in platform/graphics/{compositing,cpu,gpu,skia}/. (Closed)

Created:
4 years, 2 months ago by Peter Kasting
Modified:
4 years, 2 months ago
Reviewers:
jbroman
CC:
jbroman, ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), Justin Novosad, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrap comments to 80 columns in platform/graphics/{compositing,cpu,gpu,skia}/. This also makes some minor modifications (small rewrites for grammar, etc.). BUG=563793 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/742cd0347b9999467d82e6f8a28a7d3b5673c19d Cr-Commit-Position: refs/heads/master@{#422842}

Patch Set 1 #

Patch Set 2 : Resync #

Patch Set 3 : Another long comment #

Total comments: 2

Patch Set 4 : One space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -139 lines) Patch
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 2 5 chunks +14 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/cpu/arm/WebGLImageConversionNEON.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 12 chunks +39 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 11 chunks +43 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp View 3 chunks +12 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h View 4 chunks +17 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp View 6 chunks +25 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.h View 4 chunks +16 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (15 generated)
Peter Kasting
4 years, 2 months ago (2016-10-04 07:43:17 UTC) #5
jbroman
lgtm with one super-duper-ultra nit which you should feel free to ignore https://codereview.chromium.org/2391943002/diff/40001/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp File third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp ...
4 years, 2 months ago (2016-10-04 13:57:20 UTC) #14
Peter Kasting
https://codereview.chromium.org/2391943002/diff/40001/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp File third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp (right): https://codereview.chromium.org/2391943002/diff/40001/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp#newcode14 third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp:14: // built as a part of webkit_unittests instead blink_platform_unittests. ...
4 years, 2 months ago (2016-10-04 16:10:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391943002/60001
4 years, 2 months ago (2016-10-04 16:11:57 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-04 17:27:52 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 17:32:12 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/742cd0347b9999467d82e6f8a28a7d3b5673c19d
Cr-Commit-Position: refs/heads/master@{#422842}

Powered by Google App Engine
This is Rietveld 408576698