Implement WebGL's commit with software compositing

Implement WebGL's commit with software compositing

We already have all the code infra available, we just need to check
whether there are command-line flags --disable-gpu-compositing ||
--disable-gpu or not, also checking WebGraphicsContext3DProvider::
isSoftwareRendering.

Two pixel tests are added with --disable-gpu-compositing to make sure
that the code works.

BUG=563852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/595e3b2511f9fbeefe0f174a66a5503a13775427
Cr-Commit-Position: refs/heads/master@{#423500}

[xidachen, 2016-10-04 20:20:45]

Description was changed from

==========
Implement WebGL's commit with software compositing

We already have all the code infra available, we just need to check
whether there are command-line flags --disable-gpu-compositing ||
--disable-gpu or not, also checking WebGraphicsContext3DProvider::
isSoftwareRendering.

Two pixel tests are added with --disable-gpu-compositing to make sure
that the code works.

BUG=563852
==========

to

==========
Implement WebGL's commit with software compositing

We already have all the code infra available, we just need to check
whether there are command-line flags --disable-gpu-compositing ||
--disable-gpu or not, also checking WebGraphicsContext3DProvider::
isSoftwareRendering.

Two pixel tests are added with --disable-gpu-compositing to make sure
that the code works.

BUG=563852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[xidachen, 2016-10-04 20:20:45]

Description was changed from

==========
Implement WebGL's commit with software compositing

We already have all the code infra available, we just need to check
whether there are command-line flags --disable-gpu-compositing ||
--disable-gpu or not, also checking WebGraphicsContext3DProvider::
isSoftwareRendering.

Two pixel tests are added with --disable-gpu-compositing to make sure
that the code works.

BUG=563852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Implement WebGL's commit with software compositing

We already have all the code infra available, we just need to check
whether there are command-line flags --disable-gpu-compositing ||
--disable-gpu or not, also checking WebGraphicsContext3DProvider::
isSoftwareRendering.

Two pixel tests are added with --disable-gpu-compositing to make sure
that the code works.

BUG=563852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[xidachen, 2016-10-05 13:32:26]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org, kbr@chromium.org

[xidachen, 2016-10-05 13:32:27]

PTAL

[Justin Novosad, 2016-10-05 15:38:57]

lgtm with nit for platform/graphics

https://codereview.chromium.org/2391883004/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
(right):

https://codereview.chromium.org/2391883004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:196:
isWebGLSoftwareRendering))
Could you add a comment that explains the rationale for Software rendered WebGL?

[Ken Russell (switch to Gerrit), 2016-10-05 20:24:51]

lgtm too

https://codereview.chromium.org/2391883004/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
(right):

https://codereview.chromium.org/2391883004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:157:
// When WebGL's commit is called on swiftshade, we have software rendered WebGL.
typo: SwiftShader.

[xidachen, 2016-10-05 20:27:40]

On 2016/10/05 20:24:51, Ken Russell wrote:
> lgtm too
> 
>
https://codereview.chromium.org/2391883004/diff/80001/third_party/WebKit/Sour...
> File
>
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
> (right):
> 
>
https://codereview.chromium.org/2391883004/diff/80001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:157:
> // When WebGL's commit is called on swiftshade, we have software rendered
WebGL.
> typo: SwiftShader.

Thanks, typo fixed.

I am going wait until this CL: https://codereview.chromium.org/2391753003/
lands, and rebase on top of that.

[xidachen, 2016-10-06 00:54:43]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 00:55:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 03:52:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 03:52:33]

Dry run: This issue passed the CQ dry run.

[xidachen, 2016-10-06 11:35:18]

The CQ bit was checked by xidachen@chromium.org

[xidachen, 2016-10-06 11:35:18]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org,
kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2391883004/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-06 11:35:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 11:41:50]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-06 11:44:20]

Description was changed from

==========
Implement WebGL's commit with software compositing

We already have all the code infra available, we just need to check
whether there are command-line flags --disable-gpu-compositing ||
--disable-gpu or not, also checking WebGraphicsContext3DProvider::
isSoftwareRendering.

Two pixel tests are added with --disable-gpu-compositing to make sure
that the code works.

BUG=563852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Implement WebGL's commit with software compositing

We already have all the code infra available, we just need to check
whether there are command-line flags --disable-gpu-compositing ||
--disable-gpu or not, also checking WebGraphicsContext3DProvider::
isSoftwareRendering.

Two pixel tests are added with --disable-gpu-compositing to make sure
that the code works.

BUG=563852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/595e3b2511f9fbeefe0f174a66a5503a13775427
Cr-Commit-Position: refs/heads/master@{#423500}
==========

[commit-bot: I haz the power, 2016-10-06 11:44:20]

Patchset 7 (id:??) landed as
https://crrev.com/595e3b2511f9fbeefe0f174a66a5503a13775427
Cr-Commit-Position: refs/heads/master@{#423500}