third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 2391883004: Implement WebGL's commit with software compositing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2391883004: Implement WebGL's commit with software compositing (Closed)

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/test/gpu/gpu_tests/pixel_test_pages.py ('k') | third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

index 7d64f6bc8f80548d0bb6392800e0d6a5c0591839..5781d3626a7e08e500eb2153a93f39e23a452b33 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -704,7 +704,8 @@ void WebGLRenderingContextBase::commit(ExceptionState& exceptionState) {

// TODO(crbug.com/646864): Make commit() work correctly with

// { preserveDrawingBuffer : true }.

getOffscreenCanvas()->getOrCreateFrameDispatcher()->dispatchFrame(

- std::move(drawingBuffer()->transferToStaticBitmapImage()));

+ std::move(drawingBuffer()->transferToStaticBitmapImage()),

+ drawingBuffer()->contextProvider()->isSoftwareRendering());

}

PassRefPtr<Image> WebGLRenderingContextBase::getImage(