Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2391753003: Stop exposing --disable-gpu-compositing as a Blink RuntimeEnabledFeature (Closed)

Created:
4 years, 2 months ago by xidachen
Modified:
4 years, 2 months ago
Reviewers:
danakj, Ian Vollick, esprehn
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, Ian Vollick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop exposing --disable-gpu-compositing as a Blink RuntimeEnabledFeature My previous CL makes this flag as a RuntimeEnabledFeature under Blink which can be query anywhere in Blink. This CL move it to public/platform/Platform.h. We put an extra note in there saying that this function should never be called from core/ and modules/, should only be called from platform/graphics. BUG=650795 Committed: https://crrev.com/570d8768c9645b4c9936461087174241df70fdeb Cr-Commit-Position: refs/heads/master@{#423353}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : simplify changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M content/child/runtime_features.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
xidachen
PTAL I took Dana's advice and put this in public/platform/Platform.h with an extra note that ...
4 years, 2 months ago (2016-10-05 12:36:17 UTC) #2
esprehn
Okay, though I still think this maybe belongs as part of cc, isn't this more ...
4 years, 2 months ago (2016-10-05 19:49:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391753003/40001
4 years, 2 months ago (2016-10-06 00:17:36 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-06 00:25:13 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 00:27:35 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/570d8768c9645b4c9936461087174241df70fdeb
Cr-Commit-Position: refs/heads/master@{#423353}

Powered by Google App Engine
This is Rietveld 408576698