Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2391423002: Implement getSentBytesCount() in Cronet UrlRequest metrics (Closed)

Created:
4 years, 2 months ago by mgersh
Modified:
4 years, 2 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement getSentBytesCount() in Cronet UrlRequest metrics BUG=591434, 629194 Committed: https://crrev.com/06763af4b30a9a7b8e1a190d9f2493f9467cab67 Cr-Commit-Position: refs/heads/master@{#423287}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M components/cronet/android/cronet_url_request_adapter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 2 chunks +2 lines, -0 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java View 6 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mgersh
PTAL at this one too. Not sure why I thought this was hard, the method ...
4 years, 2 months ago (2016-10-05 20:22:23 UTC) #2
xunjieli
lgtm
4 years, 2 months ago (2016-10-05 20:52:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391423002/1
4 years, 2 months ago (2016-10-05 20:55:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 21:05:15 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 21:08:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06763af4b30a9a7b8e1a190d9f2493f9467cab67
Cr-Commit-Position: refs/heads/master@{#423287}

Powered by Google App Engine
This is Rietveld 408576698