Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java

Issue 2391423002: Implement getSentBytesCount() in Cronet UrlRequest metrics (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
index 3b106ddbabc81ec8782e95c04f2413d1bbd59010..04e1a6c64095d4a50db6f1220b53f5d49fcc2954 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
@@ -112,6 +112,7 @@ public class RequestFinishedInfoTest extends CronetTestBase {
assertNull(metrics.getPushStart());
assertNull(metrics.getPushEnd());
// Check data use metrics
+ assertTrue(metrics.getSentBytesCount() > 0);
assertTrue(metrics.getReceivedBytesCount() > 0);
mTestFramework.mCronetEngine.shutdown();
}
@@ -154,6 +155,7 @@ public class RequestFinishedInfoTest extends CronetTestBase {
assertTrue(metrics.getTotalTimeMs() >= metrics.getTtfbMs());
MetricsTestUtil.checkTimingMetrics(metrics, startTime, endTime);
MetricsTestUtil.checkHasConnectTiming(metrics, startTime, endTime, false);
+ assertTrue(metrics.getSentBytesCount() > 0);
assertTrue(metrics.getReceivedBytesCount() > 0);
mTestFramework.mCronetEngine.shutdown();
}
@@ -203,6 +205,7 @@ public class RequestFinishedInfoTest extends CronetTestBase {
assertTrue(firstMetrics.getTotalTimeMs() >= firstMetrics.getTtfbMs());
MetricsTestUtil.checkTimingMetrics(firstMetrics, startTime, endTime);
MetricsTestUtil.checkHasConnectTiming(firstMetrics, startTime, endTime, false);
+ assertTrue(firstMetrics.getSentBytesCount() > 0);
assertTrue(firstMetrics.getReceivedBytesCount() > 0);
RequestFinishedInfo.Metrics secondMetrics = secondRequestInfo.getMetrics();
assertNotNull("RequestFinishedInfo.getMetrics() must not be null", secondMetrics);
@@ -210,6 +213,7 @@ public class RequestFinishedInfoTest extends CronetTestBase {
assertTrue(secondMetrics.getTotalTimeMs() >= secondMetrics.getTtfbMs());
MetricsTestUtil.checkTimingMetrics(secondMetrics, startTime, endTime);
MetricsTestUtil.checkHasConnectTiming(secondMetrics, startTime, endTime, false);
+ assertTrue(secondMetrics.getSentBytesCount() > 0);
assertTrue(secondMetrics.getReceivedBytesCount() > 0);
mTestFramework.mCronetEngine.shutdown();
}
@@ -260,8 +264,8 @@ public class RequestFinishedInfoTest extends CronetTestBase {
|| metrics.getResponseEnd().equals(endTime));
// Entire request should take more than 0 ms
assertTrue(metrics.getResponseEnd().getTime() - metrics.getRequestStart().getTime() > 0);
-
- assertTrue(metrics.getReceivedBytesCount() == null || metrics.getReceivedBytesCount() == 0);
+ assertTrue(metrics.getSentBytesCount() == 0);
+ assertTrue(metrics.getReceivedBytesCount() == 0);
mTestFramework.mCronetEngine.shutdown();
}
@@ -331,6 +335,7 @@ public class RequestFinishedInfoTest extends CronetTestBase {
assertNull(metrics.getPushStart());
assertNull(metrics.getPushEnd());
// Check data use metrics
+ assertTrue(metrics.getSentBytesCount() > 0);
assertTrue(metrics.getReceivedBytesCount() > 0);
mTestFramework.mCronetEngine.shutdown();
}
« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698