components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java - Issue 2391423002: Implement getSentBytesCount() in Cronet UrlRequest metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Issue 2391423002: Implement getSentBytesCount() in Cronet UrlRequest metrics (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_url_request_adapter.cc ('k') | components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

index a9e1f5b076f2ecfc6f2db8f5918863c640ad7aa6..94f2ac1eecbd38ec1fc2b69e9aa110df1ce8ad11 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

@@ -235,6 +235,7 @@ public class QuicTest extends CronetTestBase {

MetricsTestUtil.checkTimingMetrics(metrics, startTime, endTime);

MetricsTestUtil.checkHasConnectTiming(metrics, startTime, endTime, true);

+ assertTrue(metrics.getSentBytesCount() > 0);

// Second request should use the same connection and not have ConnectTiming numbers

callback = new TestUrlRequestCallback();

@@ -257,6 +258,7 @@ public class QuicTest extends CronetTestBase {

MetricsTestUtil.checkTimingMetrics(metrics, startTime, endTime);

MetricsTestUtil.checkNoConnectTiming(metrics);

+ assertTrue(metrics.getSentBytesCount() > 0);

mTestFramework.mCronetEngine.shutdown();

}