Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Issue 2391423002: Implement getSentBytesCount() in Cronet UrlRequest metrics (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.net; 5 package org.chromium.net;
6 6
7 import android.os.ConditionVariable; 7 import android.os.ConditionVariable;
8 import android.test.suitebuilder.annotation.LargeTest; 8 import android.test.suitebuilder.annotation.LargeTest;
9 import android.test.suitebuilder.annotation.SmallTest; 9 import android.test.suitebuilder.annotation.SmallTest;
10 10
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 assertEquals(200, callback.mResponseInfo.getHttpStatusCode()); 228 assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
229 assertEquals("quic/1+spdy/3", callback.mResponseInfo.getNegotiatedProtoc ol()); 229 assertEquals("quic/1+spdy/3", callback.mResponseInfo.getNegotiatedProtoc ol());
230 230
231 RequestFinishedInfo requestInfo = requestFinishedListener.getRequestInfo (); 231 RequestFinishedInfo requestInfo = requestFinishedListener.getRequestInfo ();
232 assertNotNull(requestInfo); 232 assertNotNull(requestInfo);
233 RequestFinishedInfo.Metrics metrics = requestInfo.getMetrics(); 233 RequestFinishedInfo.Metrics metrics = requestInfo.getMetrics();
234 assertNotNull(metrics); 234 assertNotNull(metrics);
235 235
236 MetricsTestUtil.checkTimingMetrics(metrics, startTime, endTime); 236 MetricsTestUtil.checkTimingMetrics(metrics, startTime, endTime);
237 MetricsTestUtil.checkHasConnectTiming(metrics, startTime, endTime, true) ; 237 MetricsTestUtil.checkHasConnectTiming(metrics, startTime, endTime, true) ;
238 assertTrue(metrics.getSentBytesCount() > 0);
238 239
239 // Second request should use the same connection and not have ConnectTim ing numbers 240 // Second request should use the same connection and not have ConnectTim ing numbers
240 callback = new TestUrlRequestCallback(); 241 callback = new TestUrlRequestCallback();
241 requestFinishedListener.reset(); 242 requestFinishedListener.reset();
242 requestBuilder = new UrlRequest.Builder( 243 requestBuilder = new UrlRequest.Builder(
243 quicURL, callback, callback.getExecutor(), mTestFramework.mCrone tEngine); 244 quicURL, callback, callback.getExecutor(), mTestFramework.mCrone tEngine);
244 startTime = new Date(); 245 startTime = new Date();
245 requestBuilder.build().start(); 246 requestBuilder.build().start();
246 callback.blockForDone(); 247 callback.blockForDone();
247 requestFinishedListener.blockUntilDone(); 248 requestFinishedListener.blockUntilDone();
248 endTime = new Date(); 249 endTime = new Date();
249 250
250 assertEquals(200, callback.mResponseInfo.getHttpStatusCode()); 251 assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
251 assertEquals("quic/1+spdy/3", callback.mResponseInfo.getNegotiatedProtoc ol()); 252 assertEquals("quic/1+spdy/3", callback.mResponseInfo.getNegotiatedProtoc ol());
252 253
253 requestInfo = requestFinishedListener.getRequestInfo(); 254 requestInfo = requestFinishedListener.getRequestInfo();
254 assertNotNull(requestInfo); 255 assertNotNull(requestInfo);
255 metrics = requestInfo.getMetrics(); 256 metrics = requestInfo.getMetrics();
256 assertNotNull(metrics); 257 assertNotNull(metrics);
257 258
258 MetricsTestUtil.checkTimingMetrics(metrics, startTime, endTime); 259 MetricsTestUtil.checkTimingMetrics(metrics, startTime, endTime);
259 MetricsTestUtil.checkNoConnectTiming(metrics); 260 MetricsTestUtil.checkNoConnectTiming(metrics);
261 assertTrue(metrics.getSentBytesCount() > 0);
260 262
261 mTestFramework.mCronetEngine.shutdown(); 263 mTestFramework.mCronetEngine.shutdown();
262 } 264 }
263 } 265 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698