Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2390743005: [heap] Concurrently free empty slot set buckets. (Closed)

Created:
4 years, 2 months ago by Hannes Payer (out of office)
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Concurrently free empty slot set buckets. BUG=chromium:648568 Committed: https://crrev.com/1cb133e312a9e33c78c8cfca6e8bd59246f44d02 Cr-Commit-Position: refs/heads/master@{#39982}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -42 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/remembered-set.h View 2 chunks +6 lines, -11 lines 0 comments Download
M src/heap/remembered-set.cc View 2 chunks +17 lines, -12 lines 0 comments Download
M src/heap/slot-set.h View 6 chunks +21 lines, -3 lines 1 comment Download
M src/heap/spaces.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M test/unittests/heap/slot-set-unittest.cc View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Hannes Payer (out of office)
https://codereview.chromium.org/2390743005/diff/1/src/heap/slot-set.h File src/heap/slot-set.h (right): https://codereview.chromium.org/2390743005/diff/1/src/heap/slot-set.h#newcode28 src/heap/slot-set.h:28: enum IterationMode { PREFREE_EMPTY_BUCKETS, KEEP_EMPTY_BUCKETS }; KEEP_EMPTY_BUCKETS will be ...
4 years, 2 months ago (2016-10-05 08:59:30 UTC) #6
Michael Lippautz
lgtm
4 years, 2 months ago (2016-10-05 09:15:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390743005/1
4 years, 2 months ago (2016-10-05 09:16:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 09:26:59 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 09:27:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cb133e312a9e33c78c8cfca6e8bd59246f44d02
Cr-Commit-Position: refs/heads/master@{#39982}

Powered by Google App Engine
This is Rietveld 408576698