[Sync] Remove special cased sessions default commit

[Sync] Remove special cased sessions default commit

The session commit delay is always overridden in production. As such, the
default only affects test, where it makes it much more likely to time out.
Remove it and re-enable the disabled sessions integration tests.

BUG=263369, 232313
Committed: https://crrev.com/fee75a0f89047e1888df2746dee671c2ca0dd43b
Cr-Commit-Position: refs/heads/master@{#422668}

[Nicolas Zea, 2016-09-30 22:15:48]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 22:17:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 22:45:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 22:45:05]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Nicolas Zea, 2016-10-03 19:57:16]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 19:57:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 20:41:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 20:41:54]

Dry run: This issue passed the CQ dry run.

[Nicolas Zea, 2016-10-03 23:29:48]

zea@chromium.org changed reviewers:
+ maxbogue@chromium.org

[Nicolas Zea, 2016-10-03 23:29:49]

PTAL

[maxbogue, 2016-10-03 23:45:06]

You're saying that sessions_commit_delay_seconds is always set by the server?

https://cs.chromium.org/chromium/src/components/sync/protocol/client_commands...

If that's the case then LGTM, I see the override here:

https://cs.chromium.org/chromium/src/components/sync/engine_impl/syncer_proto...

[maxbogue, 2016-10-03 23:46:59]

Actually one followup: it doesn't matter that the FAVICON_ types aren't getting
overwritten?

[Nicolas Zea, 2016-10-03 23:58:50]

The CQ bit was checked by zea@chromium.org to run a CQ dry run

[Nicolas Zea, 2016-10-03 23:59:32]

Good catch! You're right, favicon tracking in particular would be problematic,
and is a hole in the system. I've updated the logic to affect both favicon types
now too.

[commit-bot: I haz the power, 2016-10-04 00:00:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-10-04 00:12:32]

Awesome, lgtm!

[Nicolas Zea, 2016-10-04 00:13:42]

The CQ bit was unchecked by zea@chromium.org

[Nicolas Zea, 2016-10-04 00:13:42]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2016-10-04 00:13:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 02:03:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-04 02:05:09]

Description was changed from

==========
[Sync] Remove special cased sessions default commit

The session commit delay is always overridden in production. As such, the
default only affects test, where it makes it much more likely to time out.
Remove it and re-enable the disabled sessions integration tests.

BUG=263369, 232313
==========

to

==========
[Sync] Remove special cased sessions default commit

The session commit delay is always overridden in production. As such, the
default only affects test, where it makes it much more likely to time out.
Remove it and re-enable the disabled sessions integration tests.

BUG=263369, 232313

Committed: https://crrev.com/fee75a0f89047e1888df2746dee671c2ca0dd43b
Cr-Commit-Position: refs/heads/master@{#422668}
==========

[commit-bot: I haz the power, 2016-10-04 02:05:10]

Patchset 3 (id:??) landed as
https://crrev.com/fee75a0f89047e1888df2746dee671c2ca0dd43b
Cr-Commit-Position: refs/heads/master@{#422668}