Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: components/sync/engine_impl/cycle/nudge_tracker.cc

Issue 2389443003: [Sync] Remove special cased sessions default commit (Closed)
Patch Set: Updating custom nudge delay for favicons as well: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync/engine_impl/cycle/nudge_tracker.h" 5 #include "components/sync/engine_impl/cycle/nudge_tracker.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
11 #include "base/memory/ptr_util.h" 11 #include "base/memory/ptr_util.h"
12 #include "components/sync/engine/polling_constants.h" 12 #include "components/sync/engine/polling_constants.h"
13 #include "components/sync/protocol/sync.pb.h" 13 #include "components/sync/protocol/sync.pb.h"
14 14
15 namespace syncer { 15 namespace syncer {
16 16
17 namespace { 17 namespace {
18 18
19 // Delays for syncer nudges. 19 // Delays for syncer nudges.
20 const int kDefaultNudgeDelayMilliseconds = 200; 20 const int kDefaultNudgeDelayMilliseconds = 200;
21 const int kSlowNudgeDelayMilliseconds = 2000; 21 const int kSlowNudgeDelayMilliseconds = 2000;
22 const int kDefaultSessionsCommitDelaySeconds = 10;
23 const int kSyncRefreshDelayMilliseconds = 500; 22 const int kSyncRefreshDelayMilliseconds = 500;
24 const int kSyncSchedulerDelayMilliseconds = 250; 23 const int kSyncSchedulerDelayMilliseconds = 250;
25 24
26 base::TimeDelta GetDefaultDelayForType(ModelType model_type, 25 base::TimeDelta GetDefaultDelayForType(ModelType model_type,
27 base::TimeDelta minimum_delay) { 26 base::TimeDelta minimum_delay) {
28 switch (model_type) { 27 switch (model_type) {
29 case AUTOFILL: 28 case AUTOFILL:
30 // Accompany types rely on nudges from other types, and hence have long 29 // Accompany types rely on nudges from other types, and hence have long
31 // nudge delays. 30 // nudge delays.
32 return base::TimeDelta::FromSeconds(kDefaultShortPollIntervalSeconds); 31 return base::TimeDelta::FromSeconds(kDefaultShortPollIntervalSeconds);
33 case BOOKMARKS: 32 case BOOKMARKS:
34 case PREFERENCES: 33 case PREFERENCES:
34 case SESSIONS:
35 case FAVICON_IMAGES:
36 case FAVICON_TRACKING:
35 // Types with sometimes automatic changes get longer delays to allow more 37 // Types with sometimes automatic changes get longer delays to allow more
36 // coalescing. 38 // coalescing.
37 return base::TimeDelta::FromMilliseconds(kSlowNudgeDelayMilliseconds); 39 return base::TimeDelta::FromMilliseconds(kSlowNudgeDelayMilliseconds);
38 case SESSIONS:
39 case FAVICON_IMAGES:
40 case FAVICON_TRACKING:
41 // Types with navigation triggered changes get longer delays to allow more
42 // coalescing.
43 return base::TimeDelta::FromSeconds(kDefaultSessionsCommitDelaySeconds);
44 default: 40 default:
45 return minimum_delay; 41 return minimum_delay;
46 } 42 }
47 } 43 }
48 44
49 } // namespace 45 } // namespace
50 46
51 size_t NudgeTracker::kDefaultMaxPayloadsPerType = 10; 47 size_t NudgeTracker::kDefaultMaxPayloadsPerType = 10;
52 48
53 NudgeTracker::NudgeTracker() 49 NudgeTracker::NudgeTracker()
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 GetDefaultDelayForType(type, minimum_local_nudge_delay_)); 395 GetDefaultDelayForType(type, minimum_local_nudge_delay_));
400 } 396 }
401 } 397 }
402 } 398 }
403 399
404 void NudgeTracker::SetDefaultNudgeDelay(base::TimeDelta nudge_delay) { 400 void NudgeTracker::SetDefaultNudgeDelay(base::TimeDelta nudge_delay) {
405 minimum_local_nudge_delay_ = nudge_delay; 401 minimum_local_nudge_delay_ = nudge_delay;
406 } 402 }
407 403
408 } // namespace syncer 404 } // namespace syncer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698