Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: components/sync/engine_impl/cycle/nudge_tracker.cc

Issue 2389443003: [Sync] Remove special cased sessions default commit (Closed)
Patch Set: Updating custom nudge delay for favicons as well: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine_impl/cycle/nudge_tracker.cc
diff --git a/components/sync/engine_impl/cycle/nudge_tracker.cc b/components/sync/engine_impl/cycle/nudge_tracker.cc
index e8de465ceecc32fb5a407e0af3ad36debb793937..324a28f4fe15c585c1950aa5804cd12825518c07 100644
--- a/components/sync/engine_impl/cycle/nudge_tracker.cc
+++ b/components/sync/engine_impl/cycle/nudge_tracker.cc
@@ -19,7 +19,6 @@ namespace {
// Delays for syncer nudges.
const int kDefaultNudgeDelayMilliseconds = 200;
const int kSlowNudgeDelayMilliseconds = 2000;
-const int kDefaultSessionsCommitDelaySeconds = 10;
const int kSyncRefreshDelayMilliseconds = 500;
const int kSyncSchedulerDelayMilliseconds = 250;
@@ -32,15 +31,12 @@ base::TimeDelta GetDefaultDelayForType(ModelType model_type,
return base::TimeDelta::FromSeconds(kDefaultShortPollIntervalSeconds);
case BOOKMARKS:
case PREFERENCES:
- // Types with sometimes automatic changes get longer delays to allow more
- // coalescing.
- return base::TimeDelta::FromMilliseconds(kSlowNudgeDelayMilliseconds);
case SESSIONS:
case FAVICON_IMAGES:
case FAVICON_TRACKING:
- // Types with navigation triggered changes get longer delays to allow more
+ // Types with sometimes automatic changes get longer delays to allow more
// coalescing.
- return base::TimeDelta::FromSeconds(kDefaultSessionsCommitDelaySeconds);
+ return base::TimeDelta::FromMilliseconds(kSlowNudgeDelayMilliseconds);
default:
return minimum_delay;
}

Powered by Google App Engine
This is Rietveld 408576698