components/sync/engine_impl/cycle/nudge_tracker_unittest.cc - Issue 2389443003: [Sync] Remove special cased sessions default commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/cycle/nudge_tracker_unittest.cc

Issue 2389443003: [Sync] Remove special cased sessions default commit (Closed)

Patch Set: Updating custom nudge delay for favicons as well: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/engine_impl/cycle/nudge_tracker_unittest.cc

diff --git a/components/sync/engine_impl/cycle/nudge_tracker_unittest.cc b/components/sync/engine_impl/cycle/nudge_tracker_unittest.cc

index 910171e845d95e5b633e472cabfa8c7a94b337dd..3334aacf0d1214422881eea703cbd1580e190d67 100644

--- a/components/sync/engine_impl/cycle/nudge_tracker_unittest.cc

+++ b/components/sync/engine_impl/cycle/nudge_tracker_unittest.cc

@@ -745,8 +745,8 @@ TEST_F(NudgeTrackerTest, NudgeDelayTest) {

EXPECT_GT(nudge_tracker_.RecordLocalChange(ModelTypeSet(BOOKMARKS)),

base::TimeDelta());

- // Sessions is longer than "slow nudge".

- EXPECT_GT(nudge_tracker_.RecordLocalChange(ModelTypeSet(SESSIONS)),

+ // Sessions has a "slow nudge".

+ EXPECT_EQ(nudge_tracker_.RecordLocalChange(ModelTypeSet(SESSIONS)),

nudge_tracker_.RecordLocalChange(ModelTypeSet(BOOKMARKS)));

// Favicons have the same delay as sessions.