Have HTMLElements / SVGElements constructors take a Document reference in argument

Have HTMLElements / SVGElements constructors take a Document reference in argument

Have HTMLElements / SVGElements constructors take a Document reference in argument
instead of a pointer as it can never be NULL. Most callers already have a document
reference so this change avoids having to convert them into pointers.

BUG=281400
R=haraken@chromium.org, tkent@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157125

[kenneth.r.christiansen, 2013-09-03 10:01:55]

https://codereview.chromium.org/23886003/diff/1/Source/core/html/HTMLMetaElem...
File Source/core/html/HTMLMetaElement.cpp (right):

https://codereview.chromium.org/23886003/diff/1/Source/core/html/HTMLMetaElem...
Source/core/html/HTMLMetaElement.cpp:33: inline
HTMLMetaElement::HTMLMetaElement(const QualifiedName& tagName, Document&
document)
This is great especially as the class uses Document& document() internally so
being able to pass in null here seems very wrong

[do-not-use, 2013-09-03 10:02:07]

+haraken for bindings/

[tkent, 2013-09-03 12:53:09]

lgtm

Please fix Android build.

https://codereview.chromium.org/23886003/diff/9001/Source/core/svg/SVGElement.h
File Source/core/svg/SVGElement.h (left):

https://codereview.chromium.org/23886003/diff/9001/Source/core/svg/SVGElement...
Source/core/svg/SVGElement.h:51: static PassRefPtr<SVGElement> create(const
QualifiedName&, Document*);
Don't we need this?

[do-not-use, 2013-09-03 12:59:41]

Working on fixing the Android build.

https://codereview.chromium.org/23886003/diff/9001/Source/core/svg/SVGElement.h
File Source/core/svg/SVGElement.h (left):

https://codereview.chromium.org/23886003/diff/9001/Source/core/svg/SVGElement...
Source/core/svg/SVGElement.h:51: static PassRefPtr<SVGElement> create(const
QualifiedName&, Document*);
On 2013/09/03 12:53:09, tkent wrote:
> Don't we need this?

Not anymore. It used to be needed to construct unknown SVGElements. However,
Introduced an SVGUnknownElement class in
https://src.chromium.org/viewvc/blink?view=rev&revision=155426. I forgot to
remove that factory method when I introduced SVGUnknownElement.

[do-not-use, 2013-09-03 13:05:18]

Could a bindings/ OWNER please take a look as well?

[haraken, 2013-09-03 14:32:25]

LGTM for bindings/

[do-not-use, 2013-09-03 14:36:44]

Committed patchset #5 manually as r157125 (presubmit successful).