Source/core/html/HTMLSourceElement.h - Issue 23886003: Have HTMLElements / SVGElements constructors take a Document reference in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSourceElement.h

Issue 23886003: Have HTMLElements / SVGElements constructors take a Document reference in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Another Android build fix Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLSourceElement.h

diff --git a/Source/core/html/HTMLSourceElement.h b/Source/core/html/HTMLSourceElement.h

index b1a38ca48d70ee9f32b0dec57c29dc6a4cd53db9..02378ccf5b9486d42fdaa7ee541c0ee08fe338ef 100644

--- a/Source/core/html/HTMLSourceElement.h

+++ b/Source/core/html/HTMLSourceElement.h

@@ -33,8 +33,8 @@ namespace WebCore {

class HTMLSourceElement FINAL : public HTMLElement {

public:

- static PassRefPtr<HTMLSourceElement> create(Document* document) { return create(HTMLNames::sourceTag, document); }

- static PassRefPtr<HTMLSourceElement> create(const QualifiedName&, Document*);

+ static PassRefPtr<HTMLSourceElement> create(Document& document) { return create(HTMLNames::sourceTag, document); }

+ static PassRefPtr<HTMLSourceElement> create(const QualifiedName&, Document&);

String media() const;

String type() const;

@@ -46,7 +46,7 @@ public:

void cancelPendingErrorEvent();

private:

- HTMLSourceElement(const QualifiedName&, Document*);

+ HTMLSourceElement(const QualifiedName&, Document&);

virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;

virtual void removedFrom(ContainerNode*) OVERRIDE;

« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/html/HTMLSourceElement.cpp » ('j') | no next file with comments »