Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Unified Diff: Source/core/html/track/TextTrackCue.cpp

Issue 23886003: Have HTMLElements / SVGElements constructors take a Document reference in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Another Android build fix Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/TextTrackCue.h ('k') | Source/core/html/track/TextTrackCueGeneric.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/TextTrackCue.cpp
diff --git a/Source/core/html/track/TextTrackCue.cpp b/Source/core/html/track/TextTrackCue.cpp
index 1625698eb2845b6a46e0be76298895577049856c..6648b225d356206781ac4d5836f6514693ef04a9 100644
--- a/Source/core/html/track/TextTrackCue.cpp
+++ b/Source/core/html/track/TextTrackCue.cpp
@@ -92,7 +92,7 @@ static const String& verticalGrowingRightKeyword()
// ----------------------------
-TextTrackCueBox::TextTrackCueBox(Document* document, TextTrackCue* cue)
+TextTrackCueBox::TextTrackCueBox(Document& document, TextTrackCue* cue)
: HTMLDivElement(divTag, document)
, m_cue(cue)
{
@@ -204,7 +204,7 @@ TextTrackCue::TextTrackCue(ScriptExecutionContext* context, double start, double
, m_isActive(false)
, m_pauseOnExit(false)
, m_snapToLines(true)
- , m_cueBackgroundBox(HTMLDivElement::create(toDocument(context)))
+ , m_cueBackgroundBox(HTMLDivElement::create(*toDocument(context)))
, m_displayTreeShouldChange(true)
, m_displayDirection(CSSValueLtr)
{
@@ -228,7 +228,8 @@ TextTrackCue::~TextTrackCue()
PassRefPtr<TextTrackCueBox> TextTrackCue::createDisplayTree()
{
- return TextTrackCueBox::create(ownerDocument(), this);
+ ASSERT(ownerDocument());
+ return TextTrackCueBox::create(*ownerDocument(), this);
}
PassRefPtr<TextTrackCueBox> TextTrackCue::displayTreeInternal()
« no previous file with comments | « Source/core/html/track/TextTrackCue.h ('k') | Source/core/html/track/TextTrackCueGeneric.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698