Source/core/testing/MockPagePopupDriver.cpp - Issue 23886003: Have HTMLElements / SVGElements constructors take a Document reference in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/testing/MockPagePopupDriver.cpp

Issue 23886003: Have HTMLElements / SVGElements constructors take a Document reference in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Another Android build fix Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/testing/MockPagePopupDriver.cpp

diff --git a/Source/core/testing/MockPagePopupDriver.cpp b/Source/core/testing/MockPagePopupDriver.cpp

index 966897b1eb7ba663e55c45e686d7818de399e987..5ca92ce099acd1f69494b3ff85e1db8cc4a8c32e 100644

--- a/Source/core/testing/MockPagePopupDriver.cpp

+++ b/Source/core/testing/MockPagePopupDriver.cpp

@@ -61,7 +61,8 @@ inline MockPagePopup::MockPagePopup(PagePopupClient* client, const IntRect& orig

, m_closeTimer(this, &MockPagePopup::close)

{

Document* document = mainFrame->document();

- m_iframe = HTMLIFrameElement::create(HTMLNames::iframeTag, document);

+ ASSERT(document);

+ m_iframe = HTMLIFrameElement::create(HTMLNames::iframeTag, *document);

m_iframe->setIdAttribute("mock-page-popup");

m_iframe->setInlineStyleProperty(CSSPropertyBorderWidth, 0.0, CSSPrimitiveValue::CSS_PX);

m_iframe->setInlineStyleProperty(CSSPropertyPosition, CSSValueAbsolute);

« no previous file with comments | « Source/core/testing/Internals.cpp ('k') | Source/core/xml/XSLTProcessor.cpp » ('j') | no next file with comments »