Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2387643003: Revert of Turned on SkSL->GLSL compiler (Closed)

Created:
4 years, 2 months ago by fmalita_google_do_not_use
Modified:
4 years, 2 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+529 lines, -1405 lines) Patch
M gyp/sksl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLContext.h View 4 chunks +2 lines, -15 lines 0 comments Download
M src/gpu/gl/GrGLContext.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 4 chunks +35 lines, -9 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderStringBuilder.cpp View 4 chunks +7 lines, -121 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.h View 1 chunk +14 lines, -18 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderVar.h View 1 chunk +7 lines, -3 lines 0 comments Download
M src/gpu/instanced/InstanceProcessor.cpp View 8 chunks +17 lines, -17 lines 0 comments Download
D src/sksl/README View 1 chunk +0 lines, -35 lines 0 comments Download
M src/sksl/SkSLCompiler.h View 3 chunks +0 lines, -5 lines 0 comments Download
M src/sksl/SkSLCompiler.cpp View 7 chunks +6 lines, -27 lines 0 comments Download
M src/sksl/SkSLContext.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/sksl/SkSLGLSLCodeGenerator.h View 4 chunks +2 lines, -14 lines 0 comments Download
M src/sksl/SkSLGLSLCodeGenerator.cpp View 11 chunks +25 lines, -185 lines 0 comments Download
M src/sksl/SkSLIRGenerator.h View 3 chunks +0 lines, -4 lines 0 comments Download
M src/sksl/SkSLIRGenerator.cpp View 13 chunks +17 lines, -65 lines 0 comments Download
M src/sksl/SkSLMain.cpp View 2 chunks +9 lines, -43 lines 0 comments Download
M src/sksl/SkSLParser.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/sksl/SkSLParser.cpp View 10 chunks +23 lines, -59 lines 0 comments Download
M src/sksl/SkSLSPIRVCodeGenerator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sksl/SkSLSPIRVCodeGenerator.cpp View 5 chunks +4 lines, -21 lines 0 comments Download
M src/sksl/SkSLToken.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/sksl/SkSLUtil.h View 1 chunk +5 lines, -9 lines 0 comments Download
M src/sksl/SkSLUtil.cpp View 2 chunks +0 lines, -47 lines 0 comments Download
M src/sksl/ast/SkSLASTDeclaration.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/sksl/ast/SkSLASTIndexSuffix.h View 1 chunk +3 lines, -13 lines 0 comments Download
M src/sksl/ast/SkSLASTLayout.h View 3 chunks +2 lines, -15 lines 0 comments Download
D src/sksl/ast/SkSLASTModifiersDeclaration.h View 1 chunk +0 lines, -37 lines 0 comments Download
D src/sksl/ast/SkSLASTPrecision.h View 1 chunk +0 lines, -45 lines 0 comments Download
M src/sksl/ir/SkSLIndexExpression.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/sksl/ir/SkSLIntLiteral.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/sksl/ir/SkSLLayout.h View 4 chunks +8 lines, -26 lines 0 comments Download
D src/sksl/ir/SkSLModifiersDeclaration.h View 1 chunk +0 lines, -37 lines 0 comments Download
M src/sksl/ir/SkSLProgram.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/sksl/ir/SkSLProgramElement.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/sksl/lex.sksl.c View 27 chunks +263 lines, -274 lines 0 comments Download
M src/sksl/sksl.flex View 2 chunks +1 line, -5 lines 0 comments Download
M src/sksl/sksl.include View 2 chunks +0 lines, -3 lines 0 comments Download
M src/sksl/sksl_frag.include View 1 chunk +1 line, -12 lines 0 comments Download
M tests/SkSLErrorTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/SkSLGLSLTest.cpp View 9 chunks +57 lines, -195 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
fmalita_google_do_not_use
Created Revert of Turned on SkSL->GLSL compiler
4 years, 2 months ago (2016-09-30 15:05:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387643003/1
4 years, 2 months ago (2016-09-30 15:05:12 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 15:05:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d214d6ae69c1dd9ef49fdce8fac699d00bffcdcd

Powered by Google App Engine
This is Rietveld 408576698