Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 23876006: Refactoring: get rid of the SkBenchmark void* parameter. (Closed)

Created:
7 years, 3 months ago by mtklein
Modified:
7 years, 3 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Refactoring: get rid of the SkBenchmark void* parameter. While I was doing massive sed-ing, I also converted every bench to use DEF_BENCH instead of registering the ugly manual way. BUG=

Patch Set 1 #

Patch Set 2 : clean up bad edits #

Total comments: 2

Patch Set 3 : fix formatting #

Patch Set 4 : sync to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+804 lines, -1021 lines) Patch
M bench/AAClipBench.cpp View 1 5 chunks +16 lines, -36 lines 0 comments Download
M bench/BicubicBench.cpp View 1 2 2 chunks +7 lines, -12 lines 0 comments Download
M bench/BitmapBench.cpp View 4 chunks +27 lines, -28 lines 0 comments Download
M bench/BitmapRectBench.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M bench/BitmapScaleBench.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M bench/BlurBench.cpp View 2 chunks +22 lines, -23 lines 0 comments Download
M bench/BlurImageFilterBench.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M bench/BlurRectBench.cpp View 7 chunks +43 lines, -43 lines 0 comments Download
M bench/ChartBench.cpp View 1 2 chunks +3 lines, -6 lines 0 comments Download
M bench/ChecksumBench.cpp View 1 2 chunks +5 lines, -11 lines 0 comments Download
M bench/ChromeBench.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M bench/CmapBench.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M bench/ColorFilterBench.cpp View 11 chunks +29 lines, -30 lines 0 comments Download
M bench/DashBench.cpp View 7 chunks +35 lines, -35 lines 0 comments Download
M bench/DecodeBench.cpp View 1 2 chunks +4 lines, -8 lines 0 comments Download
M bench/DeferredCanvasBench.cpp View 1 3 chunks +4 lines, -6 lines 0 comments Download
M bench/DeferredSurfaceCopyBench.cpp View 1 2 chunks +3 lines, -6 lines 0 comments Download
M bench/DisplacementBench.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M bench/FSRectBench.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M bench/FontCacheBench.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M bench/FontScalerBench.cpp View 1 2 chunks +3 lines, -6 lines 0 comments Download
M bench/GameBench.cpp View 2 chunks +12 lines, -13 lines 0 comments Download
M bench/GrMemoryPoolBench.cpp View 1 4 chunks +6 lines, -11 lines 0 comments Download
M bench/GradientBench.cpp View 3 chunks +20 lines, -20 lines 0 comments Download
M bench/HairlinePathBench.cpp View 6 chunks +22 lines, -22 lines 0 comments Download
M bench/ImageCacheBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/ImageDecodeBench.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M bench/InterpBench.cpp View 1 7 chunks +11 lines, -17 lines 0 comments Download
M bench/LightingBench.cpp View 8 chunks +19 lines, -20 lines 0 comments Download
M bench/LineBench.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M bench/MagnifierBench.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M bench/MathBench.cpp View 13 chunks +30 lines, -34 lines 0 comments Download
M bench/Matrix44Bench.cpp View 12 chunks +21 lines, -21 lines 0 comments Download
M bench/MatrixBench.cpp View 12 chunks +29 lines, -29 lines 0 comments Download
M bench/MatrixConvolutionBench.cpp View 1 2 chunks +6 lines, -11 lines 0 comments Download
M bench/MemoryBench.cpp View 1 2 chunks +3 lines, -6 lines 0 comments Download
M bench/MemsetBench.cpp View 4 chunks +19 lines, -19 lines 0 comments Download
M bench/MergeBench.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M bench/MorphologyBench.cpp View 1 2 chunks +9 lines, -22 lines 0 comments Download
M bench/MutexBench.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M bench/PathBench.cpp View 24 chunks +77 lines, -88 lines 0 comments Download
M bench/PathIterBench.cpp View 1 2 chunks +3 lines, -6 lines 0 comments Download
M bench/PathUtilsBench.cpp View 1 2 chunks +3 lines, -6 lines 0 comments Download
M bench/PerlinNoiseBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/PicturePlaybackBench.cpp View 1 4 chunks +7 lines, -11 lines 0 comments Download
M bench/PictureRecordBench.cpp View 1 5 chunks +10 lines, -14 lines 0 comments Download
M bench/PremulAndUnpremulAlphaOpsBench.cpp View 1 2 chunks +3 lines, -12 lines 0 comments Download
M bench/RTreeBench.cpp View 1 3 chunks +61 lines, -83 lines 0 comments Download
M bench/ReadPixBench.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M bench/RectBench.cpp View 1 2 3 8 chunks +33 lines, -33 lines 0 comments Download
M bench/RectoriBench.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M bench/RefCntBench.cpp View 1 7 chunks +12 lines, -20 lines 0 comments Download
M bench/RegionBench.cpp View 2 chunks +10 lines, -20 lines 0 comments Download
M bench/RegionContainBench.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M bench/RepeatTileBench.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M bench/ScalarBench.cpp View 1 6 chunks +10 lines, -15 lines 0 comments Download
M bench/ShaderMaskBench.cpp View 1 2 chunks +7 lines, -14 lines 0 comments Download
M bench/SkBenchmark.h View 3 chunks +6 lines, -6 lines 0 comments Download
M bench/SkBenchmark.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/SortBench.cpp View 2 chunks +22 lines, -22 lines 0 comments Download
M bench/StrokeBench.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M bench/TableBench.cpp View 1 2 chunks +1 line, -7 lines 0 comments Download
M bench/TextBench.cpp View 2 chunks +12 lines, -26 lines 0 comments Download
M bench/TileBench.cpp View 2 chunks +14 lines, -16 lines 0 comments Download
M bench/VertBench.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M bench/WritePixelsBench.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M bench/WriterBench.cpp View 1 2 chunks +2 lines, -5 lines 0 comments Download
M bench/XfermodeBench.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M bench/benchmain.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
7 years, 3 months ago (2013-09-10 20:39:07 UTC) #1
scroggo
lgtm https://codereview.chromium.org/23876006/diff/3001/bench/BicubicBench.cpp File bench/BicubicBench.cpp (right): https://codereview.chromium.org/23876006/diff/3001/bench/BicubicBench.cpp#newcode24 bench/BicubicBench.cpp:24: , SkFloatToScalar(y))) { This is formatted as if ...
7 years, 3 months ago (2013-09-10 21:31:15 UTC) #2
mtklein
https://codereview.chromium.org/23876006/diff/3001/bench/BicubicBench.cpp File bench/BicubicBench.cpp (right): https://codereview.chromium.org/23876006/diff/3001/bench/BicubicBench.cpp#newcode24 bench/BicubicBench.cpp:24: , SkFloatToScalar(y))) { On 2013/09/10 21:31:15, scroggo wrote: > ...
7 years, 3 months ago (2013-09-11 13:33:00 UTC) #3
scroggo
7 years, 3 months ago (2013-09-11 17:25:59 UTC) #4
On 2013/09/11 13:33:00, mtklein wrote:
> https://codereview.chromium.org/23876006/diff/3001/bench/BicubicBench.cpp
> File bench/BicubicBench.cpp (right):
> 
>
https://codereview.chromium.org/23876006/diff/3001/bench/BicubicBench.cpp#new...
> bench/BicubicBench.cpp:24: , SkFloatToScalar(y))) {
> On 2013/09/10 21:31:15, scroggo wrote:
> > This is formatted as if SkFloatToScalar(y) is a parameter to the
constructor.
> It
> > should be
> > 
> > : fScale(SkSize::Make(SkFloatToScalar(x), SkFloatToScalar(y))) {
> > 
> > or
> > 
> > : fScale(SkSize::Make(SkFloatToScalar(x),
> >                       SkFloatToScalar(y))) {
> 
> Ooh, thanks.  Overzealous reformatting!  Fixed.

lgtm

Powered by Google App Engine
This is Rietveld 408576698