Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3941)

Unified Diff: bench/ChromeBench.cpp

Issue 23876006: Refactoring: get rid of the SkBenchmark void* parameter. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: sync to head Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bench/ChecksumBench.cpp ('k') | bench/CmapBench.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/ChromeBench.cpp
diff --git a/bench/ChromeBench.cpp b/bench/ChromeBench.cpp
index fb6dcb2b2267216da125b2787739bfe3793be525..9392065e56f9c34c258cb16982d80ee52e68d9df 100644
--- a/bench/ChromeBench.cpp
+++ b/bench/ChromeBench.cpp
@@ -456,7 +456,7 @@ class ScrollGmailBench : public SkBenchmark {
N = 431
};
public:
- ScrollGmailBench(void* param) : INHERITED(param) { }
+ ScrollGmailBench() { }
protected:
@@ -491,10 +491,6 @@ private:
typedef SkBenchmark INHERITED;
};
-static inline SkBenchmark* ScrollGmailFactory(void* p) {
- return SkNEW_ARGS(ScrollGmailBench, (p));
-}
-
// Disabled this benchmark: it takes 15x longer than any other benchmark
// and is probably not giving us important information.
-//static BenchRegistry gScrollGmailReg(ScrollGmailFactory);
+// DEF_BENCH(return SkNEW(ScrollGmailBench));
« no previous file with comments | « bench/ChecksumBench.cpp ('k') | bench/CmapBench.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698