bench/GameBench.cpp - Issue 23876006: Refactoring: get rid of the SkBenchmark void* parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bench/GameBench.cpp

Issue 23876006: Refactoring: get rid of the SkBenchmark void* parameter. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: sync to head Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: bench/GameBench.cpp

diff --git a/bench/GameBench.cpp b/bench/GameBench.cpp

index 5fc9c032884d7d4fdfb33b1fb7a43ff0c50994e7..7812285344730b77a721541692064649dd5e54d6 100644

--- a/bench/GameBench.cpp

+++ b/bench/GameBench.cpp

@@ -27,11 +27,10 @@ public:

kPartial_Clear

};

- GameBench(void* param, Type type, Clear clear,

+ GameBench(Type type, Clear clear,

bool aligned = false, bool useAtlas = false,

bool useDrawVertices = false)

- : INHERITED(param)

- , fType(type)

+ : fType(type)

, fClear(clear)

, fAligned(aligned)

, fUseAtlas(useAtlas)

@@ -313,27 +312,27 @@ private:

};

// Partial clear

-DEF_BENCH( return SkNEW_ARGS(GameBench, (p, GameBench::kScale_Type,

+DEF_BENCH( return SkNEW_ARGS(GameBench, (GameBench::kScale_Type,

GameBench::kPartial_Clear)); )

-DEF_BENCH( return SkNEW_ARGS(GameBench, (p, GameBench::kTranslate_Type,

+DEF_BENCH( return SkNEW_ARGS(GameBench, (GameBench::kTranslate_Type,

GameBench::kPartial_Clear)); )

-DEF_BENCH( return SkNEW_ARGS(GameBench, (p, GameBench::kTranslate_Type,

+DEF_BENCH( return SkNEW_ARGS(GameBench, (GameBench::kTranslate_Type,

GameBench::kPartial_Clear, true)); )

-DEF_BENCH( return SkNEW_ARGS(GameBench, (p, GameBench::kRotate_Type,

+DEF_BENCH( return SkNEW_ARGS(GameBench, (GameBench::kRotate_Type,

GameBench::kPartial_Clear)); )

// Full clear

-DEF_BENCH( return SkNEW_ARGS(GameBench, (p, GameBench::kScale_Type,

+DEF_BENCH( return SkNEW_ARGS(GameBench, (GameBench::kScale_Type,

GameBench::kFull_Clear)); )

-DEF_BENCH( return SkNEW_ARGS(GameBench, (p, GameBench::kTranslate_Type,

+DEF_BENCH( return SkNEW_ARGS(GameBench, (GameBench::kTranslate_Type,

GameBench::kFull_Clear)); )

-DEF_BENCH( return SkNEW_ARGS(GameBench, (p, GameBench::kTranslate_Type,

+DEF_BENCH( return SkNEW_ARGS(GameBench, (GameBench::kTranslate_Type,

GameBench::kFull_Clear, true)); )

-DEF_BENCH( return SkNEW_ARGS(GameBench, (p, GameBench::kRotate_Type,

+DEF_BENCH( return SkNEW_ARGS(GameBench, (GameBench::kRotate_Type,

GameBench::kFull_Clear)); )

// Atlased

-DEF_BENCH( return SkNEW_ARGS(GameBench, (p, GameBench::kTranslate_Type,

+DEF_BENCH( return SkNEW_ARGS(GameBench, (GameBench::kTranslate_Type,

GameBench::kFull_Clear, false, true)); )

-DEF_BENCH( return SkNEW_ARGS(GameBench, (p, GameBench::kTranslate_Type,

+DEF_BENCH( return SkNEW_ARGS(GameBench, (GameBench::kTranslate_Type,

GameBench::kFull_Clear, false, true, true)); )

« no previous file with comments | « bench/FontScalerBench.cpp ('k') | bench/GrMemoryPoolBench.cpp » ('j') | no next file with comments »