Image Capture Linux/CrOs, implement brightness, contrast, saturation and sharpness

Image Capture Linux/CrOs, implement brightness, contrast, saturation and sharpness

This CL adds the said settings to the idl (capabilities
and settings) and wires them through image_capture.mojom
to its implementations in Fake and Linux/CrOs video capture
device.

BUG=650676
TEST= manually using [1] and a Logitech C920,
result equivalent to e.g. guvcview.

[1] ./out/gn/chrome -vmodule=*v4l2*=1 --enable-blink-features=ImageCapture --use-fake-ui-for-media-stream https://rawgit.com/Miguelao/demos/master/imagecapture.html

Committed: https://crrev.com/6d7056407d29413588771b164e82a76f819783c8
Cr-Commit-Position: refs/heads/master@{#422899}

[mcasas, 2016-10-04 02:27:06]

Description was changed from

==========
Image Capture Linux/CrOs, implement brightness, contrast, saturation and
sharpness

BUG=650676
==========

to

==========
Image Capture Linux/CrOs, implement brightness, contrast, saturation and
sharpness

This CL adds the said settings to the idl (capabilities 
and settings) and wires them through image_capture.mojom
to its implementations in Fake and Linux/CrOs video capture
device.

BUG=650676
TEST= manually using [1] and a Logitech C920,
result equivalent to e.g. guvcview.


[1] ./out/gn/chrome -vmodule=*v4l2*=1 --enable-blink-features=ImageCapture
--use-fake-ui-for-media-stream
https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

[mcasas, 2016-10-04 02:27:46]

mcasas@chromium.org changed reviewers:
+ chfremer@chromium.org, haraken@chromium.org

[mcasas, 2016-10-04 02:27:47]

haraken@ RS the blink additions plz

chfremer@ PTAL at the linux/cros implementation

[haraken, 2016-10-04 02:40:19]

WebKit/ LGTM

[chfremer, 2016-10-04 17:36:06]

lgtm % comment

https://codereview.chromium.org/2387303002/diff/1/media/capture/video/linux/v...
File media/capture/video/linux/v4l2_capture_delegate.cc (right):

https://codereview.chromium.org/2387303002/diff/1/media/capture/video/linux/v...
media/capture/video/linux/v4l2_capture_delegate.cc:468: if
(settings->has_brightness) {
Copy-paste error here and the blocks below?

[mcasas, 2016-10-04 17:43:31]

Patchset #2 (id:20001) has been deleted

[mcasas, 2016-10-04 17:44:10]

mcasas@chromium.org changed reviewers:
+ tsepez@chromium.org

[mcasas, 2016-10-04 17:44:11]

tsepez@: PTAL image_capture.mojom added fields

https://codereview.chromium.org/2387303002/diff/1/media/capture/video/linux/v...
File media/capture/video/linux/v4l2_capture_delegate.cc (right):

https://codereview.chromium.org/2387303002/diff/1/media/capture/video/linux/v...
media/capture/video/linux/v4l2_capture_delegate.cc:468: if
(settings->has_brightness) {
On 2016/10/04 17:36:06, chfremer wrote:
> Copy-paste error here and the blocks below?

Oh, hark, good catch. Done.

[Tom Sepez, 2016-10-04 18:28:16]

mojom LGTM

[mcasas, 2016-10-04 18:29:31]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-10-04 18:29:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, chfremer@chromium.org
Link to the patchset: https://codereview.chromium.org/2387303002/#ps40001
(title: "chfremer@ comments and updated global-interface-listing-expected.txt")

[commit-bot: I haz the power, 2016-10-04 18:30:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2016-10-04 18:33:24]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2016-10-04 18:48:52]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 18:49:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 18:52:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 18:52:38]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mcasas, 2016-10-04 18:56:14]

Patchset #3 (id:60001) has been deleted

[mcasas, 2016-10-04 18:56:45]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-10-04 18:56:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tsepez@chromium.org, chfremer@chromium.org
Link to the patchset: https://codereview.chromium.org/2387303002/#ps80001
(title: "Explicitly initialize to empty the new fields in the Android
implementation and rebase")

[commit-bot: I haz the power, 2016-10-04 18:57:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 20:16:09]

Description was changed from

==========
Image Capture Linux/CrOs, implement brightness, contrast, saturation and
sharpness

This CL adds the said settings to the idl (capabilities 
and settings) and wires them through image_capture.mojom
to its implementations in Fake and Linux/CrOs video capture
device.

BUG=650676
TEST= manually using [1] and a Logitech C920,
result equivalent to e.g. guvcview.


[1] ./out/gn/chrome -vmodule=*v4l2*=1 --enable-blink-features=ImageCapture
--use-fake-ui-for-media-stream
https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

to

==========
Image Capture Linux/CrOs, implement brightness, contrast, saturation and
sharpness

This CL adds the said settings to the idl (capabilities 
and settings) and wires them through image_capture.mojom
to its implementations in Fake and Linux/CrOs video capture
device.

BUG=650676
TEST= manually using [1] and a Logitech C920,
result equivalent to e.g. guvcview.


[1] ./out/gn/chrome -vmodule=*v4l2*=1 --enable-blink-features=ImageCapture
--use-fake-ui-for-media-stream
https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

[commit-bot: I haz the power, 2016-10-04 20:16:10]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-10-04 20:17:57]

Description was changed from

==========
Image Capture Linux/CrOs, implement brightness, contrast, saturation and
sharpness

This CL adds the said settings to the idl (capabilities 
and settings) and wires them through image_capture.mojom
to its implementations in Fake and Linux/CrOs video capture
device.

BUG=650676
TEST= manually using [1] and a Logitech C920,
result equivalent to e.g. guvcview.


[1] ./out/gn/chrome -vmodule=*v4l2*=1 --enable-blink-features=ImageCapture
--use-fake-ui-for-media-stream
https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

to

==========
Image Capture Linux/CrOs, implement brightness, contrast, saturation and
sharpness

This CL adds the said settings to the idl (capabilities
and settings) and wires them through image_capture.mojom
to its implementations in Fake and Linux/CrOs video capture
device.

BUG=650676
TEST= manually using [1] and a Logitech C920,
result equivalent to e.g. guvcview.

[1] ./out/gn/chrome -vmodule=*v4l2*=1 --enable-blink-features=ImageCapture
--use-fake-ui-for-media-stream
https://rawgit.com/Miguelao/demos/master/imagecapture.html

Committed: https://crrev.com/6d7056407d29413588771b164e82a76f819783c8
Cr-Commit-Position: refs/heads/master@{#422899}
==========

[commit-bot: I haz the power, 2016-10-04 20:17:59]

Patchset 3 (id:??) landed as
https://crrev.com/6d7056407d29413588771b164e82a76f819783c8
Cr-Commit-Position: refs/heads/master@{#422899}