media/capture/video/fake_video_capture_device_unittest.cc - Issue 2387303002: Image Capture Linux/CrOs, implement brightness, contrast, saturation and sharpness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/fake_video_capture_device_unittest.cc

Issue 2387303002: Image Capture Linux/CrOs, implement brightness, contrast, saturation and sharpness (Closed)

Patch Set: Explicitly initialize to empty the new fields in the Android implementation and rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/capture/video/fake_video_capture_device_unittest.cc

diff --git a/media/capture/video/fake_video_capture_device_unittest.cc b/media/capture/video/fake_video_capture_device_unittest.cc

index 8830c7dc1213fc4604b5becefc9632464a66e9f3..fa30c4821cca09cb626ec546dfad0ca1911772cc 100644

--- a/media/capture/video/fake_video_capture_device_unittest.cc

+++ b/media/capture/video/fake_video_capture_device_unittest.cc

@@ -345,6 +345,18 @@ TEST_F(FakeVideoCaptureDeviceTest, GetAndSetCapabilities) {

EXPECT_EQ(0, capabilities->color_temperature->min);

EXPECT_EQ(0, capabilities->color_temperature->max);

EXPECT_EQ(0, capabilities->color_temperature->current);

+ EXPECT_EQ(0, capabilities->brightness->min);

+ EXPECT_EQ(0, capabilities->brightness->max);

+ EXPECT_EQ(0, capabilities->brightness->current);

+ EXPECT_EQ(0, capabilities->contrast->min);

+ EXPECT_EQ(0, capabilities->contrast->max);

+ EXPECT_EQ(0, capabilities->contrast->current);

+ EXPECT_EQ(0, capabilities->saturation->min);

+ EXPECT_EQ(0, capabilities->saturation->max);

+ EXPECT_EQ(0, capabilities->saturation->current);

+ EXPECT_EQ(0, capabilities->sharpness->min);

+ EXPECT_EQ(0, capabilities->sharpness->max);

+ EXPECT_EQ(0, capabilities->sharpness->current);

// Set options: zoom to the maximum value.

const int max_zoom_value = capabilities->zoom->max;