third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl - Issue 2387303002: Image Capture Linux/CrOs, implement brightness, contrast, saturation and sharpness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl

Issue 2387303002: Image Capture Linux/CrOs, implement brightness, contrast, saturation and sharpness (Closed)

Patch Set: Explicitly initialize to empty the new fields in the Android implementation and rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp ('k') | third_party/WebKit/Source/modules/imagecapture/PhotoSettings.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl

diff --git a/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl b/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl

index e751d55a85695aaadca489b3acef87b46f73518b..7fc9b2e1774e6d0ec2f6953b34cbf8ef71c15010 100644

--- a/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl

+++ b/third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl

@@ -30,8 +30,10 @@ enum FillLightMode {

readonly attribute boolean redEyeReduction;

readonly attribute MeteringMode focusMode;

- // TODO(mcasas): Implement |brightness|, |contrast|, |saturation| and

- // |sharpness|, https://crbug.com/650676.

+ readonly attribute MediaSettingsRange brightness;

+ readonly attribute MediaSettingsRange contrast;

+ readonly attribute MediaSettingsRange saturation;

+ readonly attribute MediaSettingsRange sharpness;

readonly attribute MediaSettingsRange imageHeight;

readonly attribute MediaSettingsRange imageWidth;

readonly attribute MediaSettingsRange zoom;