media/capture/video/android/video_capture_device_android.cc - Issue 2387303002: Image Capture Linux/CrOs, implement brightness, contrast, saturation and sharpness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/android/video_capture_device_android.cc

Issue 2387303002: Image Capture Linux/CrOs, implement brightness, contrast, saturation and sharpness (Closed)

Patch Set: Explicitly initialize to empty the new fields in the Android implementation and rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/capture/video/android/video_capture_device_android.cc

diff --git a/media/capture/video/android/video_capture_device_android.cc b/media/capture/video/android/video_capture_device_android.cc

index 9554ac0215ed591ab151d6d40f023994a212c382..9769b158a9329699dddc392623a2dde3bc71f12e 100644

--- a/media/capture/video/android/video_capture_device_android.cc

+++ b/media/capture/video/android/video_capture_device_android.cc

@@ -540,6 +540,11 @@ void VideoCaptureDeviceAndroid::DoGetPhotoCapabilities(

caps.getCurrentColorTemperature();

photo_capabilities->color_temperature->max = caps.getMaxColorTemperature();

photo_capabilities->color_temperature->min = caps.getMinColorTemperature();

+ photo_capabilities->brightness = media::mojom::Range::New();

+ photo_capabilities->contrast = media::mojom::Range::New();

+ photo_capabilities->saturation = media::mojom::Range::New();

+ photo_capabilities->sharpness = media::mojom::Range::New();

callback.Run(std::move(photo_capabilities));

}